Pass ... to check_roundtrip()

hadley · hadley · commit 07c5cd99c309 · 2023-10-03T21:26:57.000-05:00
diff --git a/R/snapshot-value.R b/R/snapshot-value.R
@@ -51,6 +51,7 @@ expect_snapshot_value <- function(x,
     load(save(x)),
     label = lab,
     style = style,
+    ...,
     tolerance = tolerance
   )
 
diff --git a/tests/testthat/_snaps/snapshot-value.md b/tests/testthat/_snaps/snapshot-value.md
@@ -49,6 +49,22 @@
 
     1.2
 
+---
+
+    WAoAAAACAAQCAwACAwAAAAMGAAAEAgAAAAEABAAJAAAABWNsYXNzAAAAEAAAAAEABAAJAAAA
+    B2Zvcm11bGEAAAQCAAAAAQAEAAkAAAAMLkVudmlyb25tZW50AAAABAAAAAAAAAAEAAAAAAAA
+    AAQAAAAAAAAA+QAAAAAAAAACAAQACQAAAAh0ZXN0dGhhdAAEAAkAAAAFMy4yLjAAAAD+AAAA
+    EwAAAB0AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4A
+    AAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA
+    /gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAAEwAAAB0AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4A
+    AAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA
+    /gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAAEwAAAB0A
+    AAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA
+    /gAAAP4AAAQCAAAAAQAEAAkAAAABZgAAAwYAAAQCAAAB/wAAABAAAAABAAQACQAAAAdmb3Jt
+    dWxhAAAEAgAAAv8AAAP/AAAA/gAAAAEABAAJAAAAAX4AAAACAAAADgAAAAE/8AAAAAAAAAAA
+    AP4AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+AAAA/gAAAP4AAAD+
+    AAAA/gAAAP4AAAD+AAAI/wAAAAIAAAAOAAAAAT/wAAAAAAAAAAAA/g==
+
 # tolerance passed to check_roundtrip
 
     0.9
diff --git a/tests/testthat/test-snapshot-value.R b/tests/testthat/test-snapshot-value.R
@@ -8,6 +8,10 @@ test_that("can snapshot values", {
 
 test_that("can control snapshot value details", {
   expect_snapshot_value(1.2, tolerance = 0.1)
+
+  # including through ...
+  f <- ~ 1
+  expect_snapshot_value(f, style = "serialize", ignore_formula_env = TRUE)
 })
 
 test_that("tolerance passed to check_roundtrip", {

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,7 @@ expect_snapshot_value <- function(x,`
`51`	`51`	`load(save(x)),`
`52`	`52`	`label = lab,`
`53`	`53`	`style = style,`
	`54`	`+ ...,`
`54`	`55`	`tolerance = tolerance`
`55`	`56`	`)`
`56`	`57`