Skip to content

Commit 2115139

Browse files
authored
Upgrade SQLx dependency (#5928)
1 parent d886023 commit 2115139

File tree

6 files changed

+73
-86
lines changed

6 files changed

+73
-86
lines changed

quickwit/Cargo.lock

Lines changed: 50 additions & 75 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

quickwit/Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,8 @@ rust-embed = "6.8"
206206
rustc-hash = "2.1"
207207
rustls = "0.23"
208208
rustls-pemfile = "2.2"
209-
sea-query = { version = "0.30" }
210-
sea-query-binder = { version = "0.5", features = [
209+
sea-query = { version = "0.32" }
210+
sea-query-binder = { version = "0.7", features = [
211211
"runtime-tokio-rustls",
212212
"sqlx-postgres",
213213
] }
@@ -221,7 +221,7 @@ serde_yaml = "0.9"
221221
serial_test = { version = "3.2", features = ["file_locks"] }
222222
siphasher = "1.0"
223223
smallvec = "1"
224-
sqlx = { version = "0.7", features = [
224+
sqlx = { version = "0.8", features = [
225225
"migrate",
226226
"postgres",
227227
"runtime-tokio-rustls",

quickwit/quickwit-metastore/src/metastore/postgres/pool.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
use futures::future::BoxFuture;
1616
use futures::stream::BoxStream;
1717
use quickwit_common::metrics::GaugeGuard;
18-
use sqlx::database::HasStatement;
1918
use sqlx::pool::PoolConnection;
2019
use sqlx::pool::maybe::MaybePoolConnection;
2120
use sqlx::{
@@ -71,7 +70,11 @@ impl<'a, DB: Database> Acquire<'a> for &TrackedPool<DB> {
7170
let acquire_conn_fut = self.acquire();
7271

7372
Box::pin(async move {
74-
Transaction::begin(MaybePoolConnection::PoolConnection(acquire_conn_fut.await?)).await
73+
Transaction::begin(
74+
MaybePoolConnection::PoolConnection(acquire_conn_fut.await?),
75+
None,
76+
)
77+
.await
7578
})
7679
}
7780
}
@@ -105,7 +108,7 @@ where for<'c> &'c mut DB::Connection: Executor<'c, Database = DB>
105108
self,
106109
sql: &'q str,
107110
parameters: &'e [<Self::Database as Database>::TypeInfo],
108-
) -> BoxFuture<'e, Result<<Self::Database as HasStatement<'q>>::Statement, Error>> {
111+
) -> BoxFuture<'e, Result<<Self::Database as Database>::Statement<'q>, Error>> {
109112
self.inner_pool.prepare_with(sql, parameters)
110113
}
111114

quickwit/quickwit-proto/src/types/doc_mapping_uid.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,10 @@ impl sqlx::Type<sqlx::Postgres> for DocMappingUid {
151151

152152
#[cfg(feature = "postgres")]
153153
impl sqlx::Encode<'_, sqlx::Postgres> for DocMappingUid {
154-
fn encode_by_ref(&self, buf: &mut sqlx::postgres::PgArgumentBuffer) -> sqlx::encode::IsNull {
154+
fn encode_by_ref(
155+
&self,
156+
buf: &mut sqlx::postgres::PgArgumentBuffer,
157+
) -> Result<sqlx::encode::IsNull, sqlx::error::BoxDynError> {
155158
sqlx::Encode::<sqlx::Postgres>::encode(self.0.to_string(), buf)
156159
}
157160
}

quickwit/quickwit-proto/src/types/index_uid.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,12 @@ impl sqlx::Type<sqlx::Postgres> for IndexUid {
187187

188188
#[cfg(feature = "postgres")]
189189
impl sqlx::Encode<'_, sqlx::Postgres> for IndexUid {
190-
fn encode_by_ref(&self, buf: &mut sqlx::postgres::PgArgumentBuffer) -> sqlx::encode::IsNull {
191-
let _ = sqlx::Encode::<sqlx::Postgres>::encode(&self.index_id, buf);
192-
let _ = sqlx::Encode::<sqlx::Postgres>::encode(":", buf);
190+
fn encode_by_ref(
191+
&self,
192+
buf: &mut sqlx::postgres::PgArgumentBuffer,
193+
) -> Result<sqlx::encode::IsNull, sqlx::error::BoxDynError> {
194+
let _ = sqlx::Encode::<sqlx::Postgres>::encode(&self.index_id, buf)?;
195+
let _ = sqlx::Encode::<sqlx::Postgres>::encode(":", buf)?;
193196
sqlx::Encode::<sqlx::Postgres>::encode(self.incarnation_id.to_string(), buf)
194197
}
195198
}

0 commit comments

Comments
 (0)