Avoid C++17 if-init

dbaston · dbaston · commit f9394b9ca170 · 2024-12-07T09:01:49.000-05:00
diff --git a/include/pybind11_json/pybind11_json.hpp b/include/pybind11_json/pybind11_json.hpp
@@ -70,7 +70,8 @@ namespace pyjson
 
     inline nl::json to_json(const py::handle& obj, std::set<const PyObject*>& refs)
     {
-        if (auto ret = refs.insert(obj.ptr()); !ret.second) {
+        auto insert_ret = refs.insert(obj.ptr());
+        if (!insert_ret.second) {
             throw std::runtime_error("Circular reference detected");
         }
 

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,8 @@ namespace pyjson`
`70`	`70`
`71`	`71`	`inline nl::json to_json(const py::handle& obj, std::set<const PyObject*>& refs)`
`72`	`72`	`{`
`73`		`- if (auto ret = refs.insert(obj.ptr()); !ret.second) {`
	`73`	`+ auto insert_ret = refs.insert(obj.ptr());`
	`74`	`+ if (!insert_ret.second) {`
`74`	`75`	`throw std::runtime_error("Circular reference detected");`
`75`	`76`	`}`
`76`	`77`