-
Notifications
You must be signed in to change notification settings - Fork 1.5k
BUG: Preserve JPEG image quality by default #3516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
77f21aa to
f0f0429
Compare
73869a8 to
2b25809
Compare
|
Could we please rename Additionally, in the best case all changes would have a corresponding test as well to avoid regressions and show that the changes to indeed have the desired effect. |
Alright, done.
OK, I will add some unit tests 👍 |
5958c30 to
4d4b55c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3516 +/- ##
=======================================
Coverage 97.13% 97.14%
=======================================
Files 57 57
Lines 9784 9791 +7
Branches 1772 1775 +3
=======================================
+ Hits 9504 9511 +7
Misses 168 168
Partials 112 112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think I fixed the final issues, and I added a unit test. IMHO this is ready to be reviewed & merged. |
|
Thank you for the review @stefan6419846 👍 🙂 I think I addressed all your feedbacks. |
stefan6419846
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
|
Thank you @stefan6419846 👍 |
Fix #3515