Skip to content

Conversation

@Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Nov 10, 2025

Fix #3515

@Lucas-C Lucas-C changed the title Fix #3515 by preserving images quality by default BUG: preserve images quality by default - fix #3515 Nov 10, 2025
@Lucas-C Lucas-C force-pushed the fix-3515 branch 3 times, most recently from 77f21aa to f0f0429 Compare November 10, 2025 15:14
@Lucas-C Lucas-C force-pushed the fix-3515 branch 2 times, most recently from 73869a8 to 2b25809 Compare November 10, 2025 15:18
@stefan6419846
Copy link
Collaborator

Could we please rename pil_params to pil_parameters - or even pillow_parameters?

Additionally, in the best case all changes would have a corresponding test as well to avoid regressions and show that the changes to indeed have the desired effect.

@Lucas-C
Copy link
Member Author

Lucas-C commented Nov 10, 2025

Could we please rename pil_params to pil_parameters - or even pillow_parameters?

Alright, done.

Additionally, in the best case all changes would have a corresponding test as well to avoid regressions and show that the changes to indeed have the desired effect.

OK, I will add some unit tests 👍

@Lucas-C Lucas-C force-pushed the fix-3515 branch 2 times, most recently from 5958c30 to 4d4b55c Compare November 10, 2025 18:02
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.14%. Comparing base (4270353) to head (c619a9a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3516   +/-   ##
=======================================
  Coverage   97.13%   97.14%           
=======================================
  Files          57       57           
  Lines        9784     9791    +7     
  Branches     1772     1775    +3     
=======================================
+ Hits         9504     9511    +7     
  Misses        168      168           
  Partials      112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lucas-C Lucas-C changed the title BUG: preserve images quality by default - fix #3515 BUG: preserve JPEG images quality by default - fix #3515 Nov 11, 2025
@Lucas-C
Copy link
Member Author

Lucas-C commented Nov 11, 2025

I think I fixed the final issues, and I added a unit test.

IMHO this is ready to be reviewed & merged.

@Lucas-C
Copy link
Member Author

Lucas-C commented Nov 12, 2025

Thank you for the review @stefan6419846 👍 🙂

I think I addressed all your feedbacks.

@stefan6419846 stefan6419846 changed the title BUG: preserve JPEG images quality by default - fix #3515 BUG: Preserve JPEG image quality by default Nov 13, 2025
Copy link
Collaborator

@stefan6419846 stefan6419846 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stefan6419846 stefan6419846 merged commit 5dd8a42 into main Nov 13, 2025
17 checks passed
@stefan6419846 stefan6419846 deleted the fix-3515 branch November 13, 2025 14:40
@Lucas-C
Copy link
Member Author

Lucas-C commented Nov 13, 2025

Thank you @stefan6419846 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PageObject.images compresses JPEG images with only 75% quality, and there is no option to control this

3 participants