Skip to content

Conversation

@zrayaz1
Copy link
Contributor

@zrayaz1 zrayaz1 commented Sep 23, 2025

A stopgap fix for #810

I haven't been able to figure out why kata behaves like this but for now this does fix the observed issue.

@ConnorNelson
Copy link
Member

As a reminder from our discussion yesterday, we want to move this into sshd/enter.py with a .wait() to detect when the container stops, and sending a SIGSTOP/SIGKILL or whatever to the docker exec command. There's a few edge cases around that.

@zrayaz1
Copy link
Contributor Author

zrayaz1 commented Sep 25, 2025

I switched the implementation, but it's giving some odd behavior.
Killing the docker exec causes ssh tests to fail, currently they all pass but that's only because I only kill if it's a kata container and we don't test with any of those. It seems to work fine locally I'm not sure why killing the exec causes the tests to fail.
Another thing is that whenever the docker exec is killed there is be extra white space before the prompt shows up.

@zrayaz1
Copy link
Contributor Author

zrayaz1 commented Oct 29, 2025

@ConnorNelson I believe this is good, it works locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants