Multiple dojos in one repository #896
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dojo.yml has optional "dojos" key which is a list of dojos (normal dojo ymls) creating dojos works, files are stored internally under shared-repo hash updating is broken promoting is working challenges are working nothing for migration yet all dojos must not exist already, if any dojo fails all will fail during creation (have not tested behavior)
|
Note: going to change this functionality so creating a dojo has another extra field to specify a dojo yml path, so only one dojo will be created from the create page at a time |
|
New info: Added an extra field in dojo create to specify a dojo yml path. Dojo creation only loads a single dojo which may be part of a larger monorepo. Repositories are duplicated on disk (one per dojo) and are updated when the specific dojo is updated. |
|
We want to make sure there's no symlink/path-traversal shenanigans. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds base functionality for including multiple dojos in a single repository (CURRENTLY UNFINISHED).
As of now, the dojo.yml can optionally have a
dojoskey, which is a list of standard dojo yml objects. All modules live in the base directory, and are loaded conditionally per dojo yml object. (https://github.com/2stinkysocks/example-monorepo-dojo)Current issues:
All dojos in a shared repository must not exist during dojo creation, or they will all fail.
There is no mechanism for migrating existing dojos into a single repository.
I have not tested a lot of existing features, and there may be some side effects I haven't found.
I have not tested github ci at all.
Currently working:
Shared repositories can be loaded as usual, multiple dojos will be created.
Updating dojos will update only the one for which update was clicked. The files for shared repositories are updated any time any dojo is updated, but the database will only be changed for the dojo which update was called on (I don't think this has side effects, needs further testing). The git hash for all dojos in a single repo will be the same in the admin page.
Files for shared repos are stored under the same directory, with the format
shared-{repository_url_md5}Promoting dojos works (single boolean column change).