Chore: Remove the initEngine methods, and update Warm test. #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rachel Green <[email protected]>
rachgreen33
requested review from
PiotrSikora,
leonm1,
martijneken and
mpwarres
as code owners
PiotrSikora
reviewed
Sep 19, 2025
Signed-off-by: Rachel Green <[email protected]>
… it is more in line with other runtimes. Signed-off-by: Rachel Green <[email protected]>
Signed-off-by: Rachel Green <[email protected]>
mpwarres
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init*Engine methods are not necessary, because warm() itself initializes the engines.
This is a follow-up to #447, which added Init*Engine along with warm functionality.