Handling "false" values in select fields (#74)

Co-authored-by: Pascal Baljet <[email protected]>

Author: ricardoh

src/Components/FormSelect.php

@@ -45,7 +45,9 @@ public function __construct(
         if ($this->isNotWired()) {
             $inputName = static::convertBracketsToDots(Str::before($name, '[]'));
 
-            $default = $this->getBoundValue($bind, $inputName) ?: $default;
+            if (is_null($default)) {
+                $default = $this->getBoundValue($bind, $inputName);
+            }
 
             $this->selectedKey = old($inputName, $default);
 

tests/Feature/BindTest.php

@@ -96,7 +96,7 @@ public function it_overrides_the_default_value()
         $this->visit('/default-values-with-bound-target')
             ->seeElement('input[name="input"][value="a"]')
             ->seeInElement('textarea[name="textarea"]', 'b')
-            ->seeElement('option[value="c"]:selected')
+            ->seeElement('option[value="f"]:selected')
             ->seeElement('input[name="checkbox"]')
             ->dontSeeElement('input[name="checkbox"]:checked')
             ->seeElement('input[name="radio"]')
@@ -111,7 +111,7 @@ public function it_overrides_the_default_value_when_nested()
         $this->visit('/default-values-with-nested-bound-target')
             ->seeElement('input[name="nested[input]"][value="a"]')
             ->seeInElement('textarea[name="nested[textarea]"]', 'b')
-            ->seeElement('select[name="nested[select]"] > option[value="c"]:selected')
+            ->seeElement('select[name="nested[select]"] > option[value="f"]:selected')
             ->seeElement('input[name="nested[checkbox]"]')
             ->dontSeeElement('input[name="nested[checkbox]"]:checked')
             ->seeElement('input[name="nested[radio]"]')

tests/Feature/SelectBooleanValueTest.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace ProtoneMedia\LaravelFormComponents\Tests\Feature;
+
+use ProtoneMedia\LaravelFormComponents\Tests\TestCase;
+
+class SelectBooleanValueTest extends TestCase
+{
+    /** @test */
+    public function it_shows_the_select_field()
+    {
+        $this->registerTestRoute('select-boolean-value');
+
+        $this->visit('/select-boolean-value')
+            ->seeElement('option[value="1"]')
+            ->seeElement('option[value="0"]');
+    }
+
+    /** @test */
+    public function it_shows_the_false_value_selected()
+    {
+        $this->registerTestRoute('select-boolean-value');
+
+        $this->visit('/select-boolean-value')
+            ->seeElement('option[value="1"]')
+            ->seeElement('option[value="0"][selected="selected"]');
+    }
+}

tests/Feature/views/default-values-with-bound-target.blade.php

@@ -12,7 +12,7 @@
     @bind($target)
         <x-form-input default="d" name="input" />
         <x-form-textarea default="e" name="textarea" />
-        <x-form-select default="f" name="select" :options="['' => '', 'c' => 'c']" />
+        <x-form-select default="f" name="select" :options="['' => '', 'c' => 'c', 'f' => 'f']" />
         <x-form-checkbox :default="true" name="checkbox" />
 
         <x-form-group name="radio">

tests/Feature/views/default-values-with-nested-bound-target.blade.php

@@ -14,7 +14,7 @@
     @bind($target)
         <x-form-input default="d" name="nested[input]" />
         <x-form-textarea default="e" name="nested[textarea]" />
-        <x-form-select default="f" name="nested[select]" :options="['' => '', 'c' => 'c']" />
+        <x-form-select default="f" name="nested[select]" :options="['' => '', 'c' => 'c', 'f' => 'f']" />
         <x-form-checkbox :default="true" name="nested[checkbox]" />
 
         <x-form-group name="radio">

tests/Feature/views/select-boolean-value.blade.php

@@ -0,0 +1,7 @@
+<x-form>
+    @bind(['select' => '0'])
+        <x-form-select name="select" :options="['1' => 'Yes', '0' => 'No']" />
+    @endbind
+
+    <x-form-submit />
+</x-form>