Skip to content

fix: honor -resolvers with -scan-all-ips (#976)#977

Merged
Mzack9999 merged 1 commit into
devfrom
fix/resolvers-scan-all-ips-976
May 18, 2026
Merged

fix: honor -resolvers with -scan-all-ips (#976)#977
Mzack9999 merged 1 commit into
devfrom
fix/resolvers-scan-all-ips-976

Conversation

@dogancanbakir

Copy link
Copy Markdown
Member

Fixes #976. -resolvers was applied to the fastdialer but not to the standalone dnsx client used by the -scan-all-ips / -ip-version resolution path, so queries fell back to the dnsx default pool (1.1.1.1, 8.8.4.4, …).

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1b64a899-a505-4fc9-b043-70473e88dd98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/resolvers-scan-all-ips-976

Comment @coderabbitai help to get the list of available commands and usage tips.

@Mzack9999 Mzack9999 merged commit fb364e8 into dev May 18, 2026
9 checks passed
@Mzack9999 Mzack9999 deleted the fix/resolvers-scan-all-ips-976 branch May 18, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using -resolvers and -scan-all-ips at the same time skips provided resolvers

2 participants