Merge pull request #44 from DaleSeo/remove-global-logging

Stoping Using Root Logger with One-off Logging Setup

Author: DaleSeo

python_graphql_client/graphql_client.py

@@ -7,14 +7,13 @@
 import requests
 import websockets
 
-logging.basicConfig(level=logging.INFO, format="%(levelname)s:%(message)s")
-
 
 class GraphqlClient:
     """Class which represents the interface to make graphQL requests through."""
 
     def __init__(self, endpoint: str, headers: dict = {}, **kwargs: Any):
         """Insantiate the client."""
+        self.logger = logging.getLogger(__name__)
         self.endpoint = endpoint
         self.headers = headers
         self.options = kwargs
@@ -106,8 +105,8 @@ async def subscribe(
             async for response_message in websocket:
                 response_body = json.loads(response_message)
                 if response_body["type"] == "connection_ack":
-                    logging.info("the server accepted the connection")
+                    self.logger.info("the server accepted the connection")
                 elif response_body["type"] == "ka":
-                    logging.info("the server sent a keep alive message")
+                    self.logger.info("the server sent a keep alive message")
                 else:
                     handle(response_body["payload"])

tests/test_graphql_client.py

@@ -269,9 +269,9 @@ async def test_subscribe(self, mock_connect):
             ]
         )
 
-    @patch("logging.info")
+    @patch("logging.getLogger")
     @patch("websockets.connect")
-    async def test_does_not_crash_with_keep_alive(self, mock_connect, mock_info):
+    async def test_does_not_crash_with_keep_alive(self, mock_connect, mock_get_logger):
         """Subsribe a GraphQL subscription."""
         mock_websocket = mock_connect.return_value.__aenter__.return_value
         mock_websocket.send = AsyncMock()
@@ -288,7 +288,9 @@ async def test_does_not_crash_with_keep_alive(self, mock_connect, mock_info):
 
         await client.subscribe(query=query, handle=MagicMock())
 
-        mock_info.assert_has_calls([call("the server sent a keep alive message")])
+        mock_get_logger.return_value.info.assert_has_calls(
+            [call("the server sent a keep alive message")]
+        )
 
     @patch("websockets.connect")
     async def test_headers_passed_to_websocket_connect(self, mock_connect):