Skip to content

Fix 8277 #8307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev-2.0
Choose a base branch
from
Open

Fix 8277 #8307

wants to merge 2 commits into from
+287 −158

Conversation

@rounittxx
Copy link

@rounittxx rounittxx commented Dec 1, 2025 •
edited
Loading

Resolves #8277

Changes

This PR refactors the implementation of arc() and ellipse() for both 2D and WebGL renderers to use the new ShapePrimitive architecture.
Key updates include:

  • Added Ellipse and Arc ShapePrimitive classes in custom_shapes.js
  • Added visitor support (visitEllipse, visitArc) in PrimitiveToPath2DConverter and PrimitiveToVerticesConverter
  • Updated Renderer2D arc and ellipse functions to use primitive + visitor pattern for consistent tessellation, fill, and stroke handling
  • Improved PIE / CHORD behavior and consistent path construction
  • Updated RendererGL ellipse() to forward to the new arc implementation and generate proper primitives
  • Updated screenshot tests for shape modes to reflect new behavior

PR Checklist

@rounittxx rounittxx changed the base branch from main to dev-2.0 December 1, 2025 12:44
@rounittxx rounittxx marked this pull request as ready for review December 1, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rounittxx