Merge pull request #1814 from Ateina/1101-filepicker-cannot-enter-link-manually

#1101: Fix issue with adding link by typing in FilePicker "From a link" tab

Author: joaojmendes

src/controls/filePicker/LinkFilePickerTab/LinkFilePickerTab.tsx

@@ -34,7 +34,6 @@ export default class LinkFilePickerTab extends React.Component<ILinkFilePickerTa
             className={styles.linkTextField}
             label={strings.LinkFileInstructions}
             ariaLabel={strings.LinkFileInstructions}
-            defaultValue={"https://"}
             onGetErrorMessage={(value: string) => this._getErrorMessagePromise(value)}
             autoAdjustHeight={false}
             underlined={false}
@@ -64,7 +63,7 @@ export default class LinkFilePickerTab extends React.Component<ILinkFilePickerTa
    * Called as user types in a new value
    */
   private _handleChange = (fileUrl: string): void => {
-    const filePickerResult: IFilePickerResult = fileUrl && this._isUrl(fileUrl) ? {
+    const filePickerResult: IFilePickerResult = fileUrl ? {
       fileAbsoluteUrl: fileUrl,
       fileName: GeneralHelper.getFileNameFromUrl(fileUrl),
       fileNameWithoutExtension: GeneralHelper.getFileNameWithoutExtension(fileUrl),
@@ -81,15 +80,15 @@ export default class LinkFilePickerTab extends React.Component<ILinkFilePickerTa
    */
   private _getErrorMessagePromise = async (value: string): Promise<string> => {
     // DOn't give an error for blank or placeholder value, but don't make it a valid entry either
-    if (value === undefined || value === 'https://') {
+    if (value === undefined || value === '') {
       this.setState({ isValid: false });
       return '';
     }
 
     // Make sure that user is typing a valid URL format
     if (!this._isUrl(value)) {
       this.setState({ isValid: false });
-      return '';
+      return strings.InvalidUrlError;
     }
 
     // If we don't allow external links, verify that we're in the same domain