fix: auto-regenerate OpenAPI spec on push to main

The CI check only ran on PRs, so direct pushes to main silently drifted
the spec. This caused the fetchOrderBook side parameter (added in
v2.37.0) to never reach the MCP or SDKs.

Author: realfishsam

.github/workflows/openapi-check.yml

@@ -4,11 +4,26 @@ on:
   pull_request:
     paths:
       - 'core/src/BaseExchange.ts'
+      - 'core/src/types.ts'
+      - 'core/src/router/types.ts'
+      - 'core/src/utils/math.ts'
+      - 'core/src/server/exchange-factory.ts'
+      - 'core/scripts/generate-openapi.js'
       - '.github/workflows/openapi-check.yml'
+  push:
+    branches: [main]
+    paths:
+      - 'core/src/BaseExchange.ts'
+      - 'core/src/types.ts'
+      - 'core/src/router/types.ts'
+      - 'core/src/utils/math.ts'
+      - 'core/src/server/exchange-factory.ts'
+      - 'core/scripts/generate-openapi.js'
 
 jobs:
   verify-spec:
     name: Verify OpenAPI spec is up-to-date
+    if: github.event_name == 'pull_request'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -25,10 +40,43 @@ jobs:
 
       - name: Check if spec changed
         run: |
-          if git diff --exit-code core/src/server/openapi.yaml; then
-            echo "✓ OpenAPI spec is up-to-date"
+          if git diff --exit-code core/src/server/openapi.yaml core/src/server/method-verbs.json; then
+            echo "OpenAPI spec is up-to-date"
           else
-            echo "✗ OpenAPI spec is out of sync with BaseExchange.ts"
+            echo "OpenAPI spec is out of sync with source files"
             echo "Run: npm run generate:openapi --workspace=pmxt-core"
             exit 1
           fi
+
+  auto-regenerate:
+    name: Auto-regenerate OpenAPI spec
+    if: github.event_name == 'push'
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: main
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+
+      - name: Install dependencies
+        run: npm install --workspace=pmxt-core
+
+      - name: Regenerate OpenAPI spec
+        run: npm run generate:openapi --workspace=pmxt-core
+
+      - name: Commit if changed
+        run: |
+          git config user.name "github-actions[bot]"
+          git config user.email "github-actions[bot]@users.noreply.github.com"
+          git add core/src/server/openapi.yaml core/src/server/method-verbs.json
+          if ! git diff --cached --quiet; then
+            git commit -m "chore: auto-regenerate OpenAPI spec"
+            git push origin main
+          else
+            echo "OpenAPI spec is already up-to-date"
+          fi

.github/workflows/publish.yml

@@ -64,6 +64,9 @@ jobs:
       - name: Fetch OpenAPI Specs
         run: npm run fetch:openapi --workspace=pmxt-core
 
+      - name: Regenerate OpenAPI spec
+        run: npm run generate:openapi --workspace=pmxt-core
+
       - name: Generate SDKs
         run: npm run generate:sdk:all --workspace=pmxt-core
 

changelog.md

@@ -2,6 +2,33 @@
 
 All notable changes to this project will be documented in this file.
 
+## [2.37.5] - 2026-05-04
+
+### Fix: OpenAPI spec not auto-regenerated on direct pushes to main
+
+- The CI check for OpenAPI spec drift only ran on pull requests. Direct
+  pushes to main bypassed the check entirely, allowing the spec (and
+  downstream MCP + SDKs) to silently drift from `BaseExchange.ts`.
+- The `openapi-check` workflow now auto-regenerates and commits the
+  sidecar spec on push to main. The PR check-and-fail behavior is
+  unchanged.
+- The path trigger now watches all source files the generator reads
+  (`types.ts`, `router/types.ts`, `math.ts`, `exchange-factory.ts`),
+  not just `BaseExchange.ts`.
+- The publish workflow now runs `generate:openapi` before SDK generation
+  as a safety net.
+
+### Fix: `fetchOrderBook` `side` parameter missing from OpenAPI spec
+
+- The optional `side` parameter added in v2.37.0 was never propagated to
+  the OpenAPI spec because the commit was pushed directly to main
+  (bypassing the PR-only CI check above).
+- The `paramKind` classifier in `generate-openapi.js` did not recognize
+  string literal unions (`'yes' | 'no'`), causing methods with such
+  parameters to incorrectly flip from GET to POST. String literal unions
+  are now classified as `string`, keeping `fetchOrderBook` as GET with
+  `side` as a query parameter.
+
 ## [2.37.4] - 2026-05-03
 
 ### Fix: Polymarket `fetchOrderBook` returns `timestamp: null`

core/scripts/generate-openapi.js

@@ -1221,17 +1221,24 @@ function paramKind(typeNode) {
     case ts.SyntaxKind.TypeLiteral:
       return 'object';
     case ts.SyntaxKind.UnionType: {
-      // Allow unions of named object types as object-kind (fetchTrades
-      // takes `TradesParams | HistoryFilterParams`, etc.). Reject other
-      // unions as unknown so we fall back to POST.
       const members = typeNode.types.filter(
         t =>
           t.kind !== ts.SyntaxKind.NullKeyword &&
           t.kind !== ts.SyntaxKind.UndefinedKeyword
       );
+      // Union of named object types → object-kind (fetchTrades takes
+      // `TradesParams | HistoryFilterParams`, etc.)
       if (members.every(t => t.kind === ts.SyntaxKind.TypeReference)) {
         return 'object';
       }
+      // Union of string literals → string-kind (fetchOrderBook takes
+      // `side?: 'yes' | 'no'`). These serialize as query params fine.
+      if (members.every(t =>
+        t.kind === ts.SyntaxKind.LiteralType &&
+        t.literal.kind === ts.SyntaxKind.StringLiteral
+      )) {
+        return 'string';
+      }
       return 'unknown';
     }
     default:

core/src/server/method-verbs.json

@@ -91,6 +91,11 @@
         "name": "id",
         "kind": "string",
         "optional": false
+      },
+      {
+        "name": "side",
+        "kind": "string",
+        "optional": true
       }
     ]
   },
@@ -229,7 +234,7 @@
       },
       {
         "name": "side",
-        "kind": "unknown",
+        "kind": "string",
         "optional": false
       },
       {
@@ -249,7 +254,7 @@
       },
       {
         "name": "side",
-        "kind": "unknown",
+        "kind": "string",
         "optional": false
       },
       {

core/src/server/openapi.yaml

@@ -640,6 +640,11 @@ paths:
           required: true
           schema:
             type: string
+        - in: query
+          name: side
+          required: false
+          schema:
+            type: string
       responses:
         '200':
           description: Fetch Order Book response