fix: add required sort kwarg to ProductAttributes#list

The OpenAPI spec marks sort as required: true on
listProductAttributes, but the gem method signature only took
page: and size:. A real API call would have come back 400. The
existing test passed because WebMock's query matcher is a subset
match — the stub had only page+size and didn't notice the
missing sort.

Also adds a ProductAttributes#each method for full-iteration
ergonomics, mirroring the each helpers on Products and
Structures. The shared paginate_through helper in Resources::Base
forwards only kwargs, so a custom each is needed for resources
whose list method takes a positional id (in this case product_id).

Found via a systematic spec-vs-gem audit script. All other
operations had their required query params declared correctly.

Author: ovelar

lib/feed_pim/resources/product_attributes.rb

@@ -4,14 +4,27 @@ module FeedPim
   module Resources
     class ProductAttributes < Base
       operation :listProductAttributes
-      def list(product_id, page:, size:)
+      def list(product_id, page:, size:, sort:)
         request(
           :get, "/v2/products/#{product_id}/attributes",
-          params: { page: page, size: size },
+          params: { page: page, size: size, sort: sort },
           decoder: :decode_page_of_product_attribute
         )
       end
 
+      def each(product_id, size: 100, sort: ["sortNo,asc"], &block)
+        return to_enum(:each, product_id, size: size, sort: sort) unless block_given?
+
+        page_index = 0
+        loop do
+          page = list(product_id, page: page_index, size: size, sort: sort)
+          page.content.each(&block)
+          break if page.last?
+
+          page_index += 1
+        end
+      end
+
       operation :getProductAttribute
       def get(product_id, attribute_id)
         request(

spec/feed_pim/resources/product_attributes_spec.rb

@@ -3,19 +3,37 @@
 RSpec.describe FeedPim::Resources::ProductAttributes do
   include_context "with client"
 
-  it "lists product attributes (paginated)" do
+  it "lists product attributes (paginated, with required sort)" do
     stub_request(:get, "#{api_url}/v2/products/p1/attributes")
-      .with(query: { page: "0", size: "100" })
+      .with(query: { page: "0", size: "100", sort: "sortNo,asc" })
       .to_return(status: 200,
                  body: { content: [{ attributeId: "a", dataType: "TEXT" }],
                          totalElements: 1, totalPages: 1, size: 100, number: 0 }.to_json,
                  headers: { "Content-Type" => "application/json" })
 
-    page = client.product_attributes.list("p1", page: 0, size: 100)
+    page = client.product_attributes.list("p1", page: 0, size: 100, sort: ["sortNo,asc"])
     expect(page.content.first).to be_a(FeedPim::Types::ProductAttribute)
     expect(page.content.first.attribute_id).to eq("a")
   end
 
+  it "iterates every attribute across all pages with #each" do
+    stub_request(:get, "#{api_url}/v2/products/p1/attributes")
+      .with(query: { page: "0", size: "200", sort: "sortNo,asc" })
+      .to_return(status: 200,
+                 body: { content: [{ attributeId: "a1" }], totalElements: 2,
+                         totalPages: 2, size: 200, number: 0 }.to_json,
+                 headers: { "Content-Type" => "application/json" })
+    stub_request(:get, "#{api_url}/v2/products/p1/attributes")
+      .with(query: { page: "1", size: "200", sort: "sortNo,asc" })
+      .to_return(status: 200,
+                 body: { content: [{ attributeId: "a2" }], totalElements: 2,
+                         totalPages: 2, size: 200, number: 1 }.to_json,
+                 headers: { "Content-Type" => "application/json" })
+
+    ids = client.product_attributes.each("p1", size: 200).map(&:attribute_id)
+    expect(ids).to eq(%w[a1 a2])
+  end
+
   it "gets a single product attribute" do
     stub_request(:get, "#{api_url}/v2/products/p1/attributes/a")
       .to_return(status: 200,