Skip to content

Conversation

@pralor-bot
Copy link
Collaborator

Automated PR to update pihole.toml documentation from FTL build.

@pralor-bot pralor-bot requested a review from a team as a code owner July 2, 2025 22:10
@netlify
Copy link

netlify bot commented Jul 2, 2025

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit cd45651
🔍 Latest deploy log https://app.netlify.com/projects/pihole-docs/deploys/68fc9e626c008200080e8bd9
😎 Deploy Preview https://deploy-preview-1258--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pralor-bot pralor-bot force-pushed the update-pihole-toml-docs branch 4 times, most recently from 101b5a9 to f5f4ccf Compare July 3, 2025 12:08
@rdwebdesign
Copy link
Member

@PromoFaux

One of the linting rules is wrongly identifying 2 asterisks as italic markers.

image

Since these asterisks are normal text (not used to format the text as Italic), they contain spaces around them and this is triggering the MD037 rule:

This is the text. The highlighted part is not in italic, but the linter is throwing an error:

format, and it must have both, private key and certificate (the *.pem file created must contain a 'CERTIFICATE' section as well as a 'RSA PRIVATE KEY' section). The *.pem file can be created using cp server.crt server.pem

The same happens here, between the 2 _esni (lines 69 and 78).

Maybe we need to escape asterisks and underscores, or just disable rule MD037 for the file.

@pralor-bot pralor-bot force-pushed the update-pihole-toml-docs branch from f5f4ccf to 4853202 Compare July 3, 2025 16:27
@PromoFaux
Copy link
Member

Already identified and fixed - see latest commit :)

@rdwebdesign

This comment was marked as outdated.

@pralor-bot pralor-bot force-pushed the update-pihole-toml-docs branch from 5653c48 to 6a67c00 Compare July 4, 2025 02:05
@rdwebdesign

This comment was marked as outdated.

@pralor-bot pralor-bot force-pushed the update-pihole-toml-docs branch 6 times, most recently from d701b61 to 0467c51 Compare July 6, 2025 22:45
@pralor-bot pralor-bot force-pushed the update-pihole-toml-docs branch 8 times, most recently from 4e217d6 to b1107ad Compare July 8, 2025 22:54
@pralor-bot pralor-bot force-pushed the update-pihole-toml-docs branch from b1107ad to 62d8581 Compare July 8, 2025 23:01
@rdwebdesign
Copy link
Member

The current code will fail tests until we merge #1263.

@rdwebdesign
Copy link
Member

We need to wait to merge this until the FTL code that generates/updates this PR is on master.

@yubiuser
Copy link
Member

Should we add a comment on top if this file that it should not changes directly in this repo, but over at FTL?

@yubiuser
Copy link
Member

pi-hole/FTL#2580

@pralor-bot pralor-bot force-pushed the update-pihole-toml-docs branch from 383d965 to cd45651 Compare October 25, 2025 09:54
@PromoFaux PromoFaux merged commit a88c5a3 into master Oct 25, 2025
11 checks passed
@PromoFaux PromoFaux deleted the update-pihole-toml-docs branch October 25, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation request: link out to all FTLCONF settings from {docs}/docker/configuration

5 participants