Skip to content

Commit 3970fde

Browse files
committed
Adapt test output to V8 5.7
1 parent 6971b84 commit 3970fde

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

tests/extensions_error.phpt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ if(strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') {
1717

1818
if(preg_match("/V8 Engine Linked Version => (.*)/", $minfo, $matches)) {
1919
$version = explode('.', $matches[1]);
20-
if($version[0] < 3 || ($version[0] == 3 && $version[1] < 30)) {
20+
if($version[0] < 5 || ($version[0] == 5 && $version[1] < 7)) {
2121
// old v8 version, has shorter error message and hence doesn't
2222
// fit our EXCEPTF below
23-
echo "skip";
23+
echo "SKIP too old V8 version";
2424
}
2525
}
2626

@@ -39,8 +39,6 @@ var_dump($v8);
3939
--EXPECTF--
4040
-- registerExtension --
4141
-- creating V8Js object --
42-
Exception thrown during bootstrapping
43-
Extension or internal compilation error%sin handlebars at line 1.
4442
Error installing extension 'handlebars'.
4543

4644
Fatal error: Uncaught V8JsException: Failed to create V8 context. Check that registered extensions do not have errors. in %s%eextensions_error.php:7

0 commit comments

Comments
 (0)