Fix URLs and search configuration usage.

Author: niconoe-

src/Hal/Report/Violations/Xml/Reporter.php

@@ -95,7 +95,7 @@ private function createXmlViolationItem(Violation $violation): DOMElement
         $item->setAttribute('beginLine', '1');
         $item->setAttribute('rule', $violationName);
         $item->setAttribute('ruleset', $violationName);
-        $item->setAttribute('externalInfoUrl', 'http://www.phpmetrics.org/documentation/index.html');
+        $item->setAttribute('externalInfoUrl', 'http://www.phpmetrics.org');
         $item->setAttribute('priority', (string)(4 - $violation->getLevel())); // Priority = reversed level.
         $item->nodeValue = $violation->getDescription();
 

src/Hal/Search/Search.php

@@ -8,6 +8,7 @@
 use Hal\Metric\InterfaceMetric;
 use Hal\Metric\Metric;
 use Hal\Metric\Registry;
+use function array_combine;
 use function array_filter;
 use function array_intersect_key;
 use function array_key_exists;
@@ -39,12 +40,13 @@ private function __construct(
      * Builds a list of Search object from the array given in argument.
      *
      * @param array<string, array<string, mixed>> $searches
-     * @return array<int, Search>
+     * @return array<string, Search>
      */
     public static function buildListFromArray(array $searches): array
     {
         $builder = static fn (string $name, array $search): Search => new self($name, $search);
-        return array_map($builder, array_keys($searches), $searches);
+        $searchesNames = array_keys($searches);
+        return array_combine($searchesNames, array_map($builder, $searchesNames, $searches));
     }
 
     /**

tests/Report/Violations/Xml/ReporterTest.php

@@ -147,7 +147,7 @@ public function testViolationsXmlReportWithViolations(): void
             return '<violation beginLine="1" '
                 . 'rule="Violation #' . $violationIndex . '" '
                 . 'ruleset="Violation #' . $violationIndex . '" '
-                . 'externalInfoUrl="http://www.phpmetrics.org/documentation/index.html" '
+                . 'externalInfoUrl="http://www.phpmetrics.org" '
                 . 'priority="' . 4 - ($violationIndex % 4) . '">'
                 . 'Description about ' . $violationIndex
                 . '</violation>';

tests/Search/SearchTest.php

@@ -26,7 +26,12 @@ public function testICanBuildSearchObjects(): void
             'withNestedData' => ['foo' => 'FOO-FOO', 'bar' => ['bar' => ['bar' => 'BAR']]],
         ];
 
-        [$searchA, $searchB, $searchC] = Search::buildListFromArray($rawArrayOfSearches);
+        $list = Search::buildListFromArray($rawArrayOfSearches);
+        self::assertCount(3, $list);
+        self::assertArrayHasKey('empty', $list);
+        self::assertArrayHasKey('withData', $list);
+        self::assertArrayHasKey('withNestedData', $list);
+        [$searchA, $searchB, $searchC] = $list;
 
         self::assertSame('empty', $searchA->getName());
         self::assertSame([], $searchA->getConfig());