use phpstan 2 and remove unnecessary checks that strict typing already covers

Author: dbu

composer.json

@@ -34,7 +34,7 @@
     "require-dev": {
         "ramsey/uuid": "^3.5",
         "phpunit/phpunit": "^7.5 || ^8.0 || ^9.0",
-        "phpstan/phpstan": "^1.9",
+        "phpstan/phpstan": "^2.1",
         "friendsofphp/php-cs-fixer": "^3.40"
     },
     "suggest": {

phpstan.neon.dist

@@ -9,8 +9,3 @@ parameters:
             message: "#^Empty array passed to foreach\\.$#"
             count: 5
             path: src/PHPCR/Util/Console/Helper/PhpcrHelper.php
-        # only formulated in phpdoc that the return value must be countable
-        -
-            message: "#expects array|Countable, Iterator<mixed, PHPCR\\Query\\RowInterface> given\\.$#"
-            count: 1
-            path: src/PHPCR/Util/Console/Command/NodesUpdateCommand.php

src/PHPCR/Util/CND/Parser/AbstractParser.php

@@ -44,7 +44,7 @@ protected function checkToken(int $type, ?string $data = null, bool $ignoreCase
         }
 
         if ($data && $token->getData() !== $data) {
-            if ($ignoreCase && is_string($data) && is_string($token->getData())) {
+            if ($ignoreCase) {
                 return 0 !== strcasecmp($data, $token->getData());
             }
 

src/PHPCR/Util/QOM/Sql2Generator.php

@@ -270,7 +270,7 @@ public function evalColumns(iterable $columns): string
     public function evalColumn(string $selectorName, ?string $propertyName = null, ?string $colname = null): string
     {
         $sql2 = '';
-        if (null !== $selectorName && null === $propertyName && null === $colname) {
+        if (null === $propertyName && null === $colname) {
             $sql2 .= $this->addBracketsIfNeeded($selectorName).'.*';
         } else {
             $sql2 .= $this->evalPropertyValue($propertyName, $selectorName);