Skip to content

Commit 84ed66c

Browse files
committed
Provide default values on trait and remove TODO
1 parent bebdf8a commit 84ed66c

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/MenuItem/SelectableTrait.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ trait SelectableTrait
1616
/**
1717
* @var string
1818
*/
19-
private $text;
19+
private $text = '';
2020

2121
/**
2222
* @var bool
@@ -26,7 +26,7 @@ trait SelectableTrait
2626
/**
2727
* @var bool
2828
*/
29-
private $disabled;
29+
private $disabled = false;
3030

3131
/**
3232
* The output text for the item

src/MenuStyle.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ class MenuStyle
139139
* @param TerminalInterface $terminal
140140
* @throws InvalidInstantiationException
141141
*/
142-
// TODO: Disabled marker ideally without breaking change.
143142
public function __construct(
144143
$bg = 'blue',
145144
$fg = 'white',
@@ -440,7 +439,6 @@ public function setUnselectedMarker($marker)
440439
*/
441440
public function getMarker($selected)
442441
{
443-
// TODO: Incorperate disabled markers ?
444442
return $selected ? $this->selectedMarker : $this->unselectedMarker;
445443
}
446444

0 commit comments

Comments
 (0)