Skip to content

Commit c780605

Browse files
authored
Merge pull request #90 from tyrsson/explore-adapter-manager-removal
This commit removes the adapter manager and rewires dependency mapping to target the service container directly.
2 parents f2528f4 + 769a857 commit c780605

8 files changed

Lines changed: 5 additions & 133 deletions

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
},
3131
"require": {
3232
"php": "~8.2.0 || ~8.3.0 || ~8.4.0 || ~8.5.0",
33-
"laminas/laminas-servicemanager": "^4.0.0",
33+
"laminas/laminas-servicemanager": "^3.0.0 || ^4.0.0",
3434
"laminas/laminas-stdlib": "^3.20.0"
3535
},
3636
"require-dev": {

src/ConfigProvider.php

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ public function __invoke(): array
1515

1616
public function getDependencies(): array
1717
{
18-
return [
19-
'factories' => [
20-
Adapter\AdapterInterface::class => Container\AdapterServiceFactory::class,
21-
Container\AdapterManager::class => Container\AdapterManagerFactory::class,
22-
],
23-
];
18+
return [];
2419
}
2520
}

src/Container/AdapterAbstractServiceFactory.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,15 @@ public function __invoke(
4545
string $requestedName,
4646
?array $options = null
4747
): AdapterInterface {
48-
$manager = $container->get(AdapterManager::class);
49-
$driverFactory = ($manager->get(DriverInterfaceFactoryFactoryInterface::class))($container, $requestedName);
48+
$driverFactory = ($container->get(DriverInterfaceFactoryFactoryInterface::class))($container, $requestedName);
5049
$driverInstance = $driverFactory::createFromConfig($container, $requestedName);
51-
$platformFactory = ($manager->get(PlatformInterfaceFactoryFactoryInterface::class))();
50+
$platformFactory = ($container->get(PlatformInterfaceFactoryFactoryInterface::class))();
5251

5352
//$config = $this->getConfig($container);
5453
return new Adapter(
5554
$driverInstance,
5655
$platformFactory::fromDriver($driverInstance),
57-
$manager->get(ResultSetInterface::class),
56+
$container->get(ResultSetInterface::class),
5857
);
5958
}
6059

src/Container/AdapterManager.php

Lines changed: 0 additions & 27 deletions
This file was deleted.

src/Container/AdapterManagerFactory.php

Lines changed: 0 additions & 15 deletions
This file was deleted.

src/Container/AdapterServiceFactory.php

Lines changed: 0 additions & 21 deletions
This file was deleted.

src/Container/MetadataFactory.php

Lines changed: 0 additions & 33 deletions
This file was deleted.

src/Container/SqlPlatformFactory.php

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)