Reworked exchangeArray in RowGateway to correct behaviour

simon-mundy · simon-mundy · commit 226e5f5253a9 · 2026-01-12T13:06:42.000+11:00
diff --git a/src/RowGateway/AbstractRowGateway.php b/src/RowGateway/AbstractRowGateway.php
@@ -82,11 +82,8 @@ public function populate(array $rowData, bool $rowExistsInDatabase = false): Row
     }
 
     /**
-     * Exchanges internal state from the given data.
-     *
-     * @deprecated since 1.0.0 — BC layer for pre-PhpDb
-     *             Will be removed or signature changed in 1.0.0.
-     *             Consumers should treat the return value as an array.
+     * docs: Behaviour has changed - this no longer returns RowGatewayInterface but
+     *       instead an array of the old data as per original PHP spec.
      *
      * @return array<string, mixed>
      */

Original file line number	Diff line number	Diff line change
`@@ -82,11 +82,8 @@ public function populate(array $rowData, bool $rowExistsInDatabase = false): Row`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`/**`
`85`		`- * Exchanges internal state from the given data.`
`86`		`- *`
`87`		`- * @deprecated since 1.0.0 — BC layer for pre-PhpDb`
`88`		`- * Will be removed or signature changed in 1.0.0.`
`89`		`- * Consumers should treat the return value as an array.`
	`85`	`+ * docs: Behaviour has changed - this no longer returns RowGatewayInterface but`
	`86`	`+ * instead an array of the old data as per original PHP spec.`
`90`	`87`	`*`
`91`	`88`	`* @return array<string, mixed>`
`92`	`89`	`*/`