fix: rename to subpath must fail

Author: abose

dist/virtualfs.js

@@ -163,7 +163,10 @@ const fileSystemLib = {
                 cb(...args);
             }
         }
-
+        if (_isSubPathOf(oldPath, newPath)){
+            callbackInterceptor(new Errors.EINVAL(`Error renaming: ${newPath} cannot be a subpath of ${oldPath}`));
+            return ;
+        }
         if(Mounts.isMountPath(oldPath) || Mounts.isMountPath(newPath)) {
             throw new Errors.EPERM('Mount root directory cannot be deleted.');
         } else if(Mounts.isMountSubPath(oldPath) && Mounts.isMountSubPath(newPath)) {

dist/virtualfs.js.map

@@ -185,6 +185,17 @@ describe('Browser main tests', function () {
         expect(failed).to.be.true;
     });
 
+    it('Should phoenix rename fail if dst is a subpath of src', async function () {
+        let errored = false;
+        fs.rename('/a', '/a/b', (err)=>{
+            if(err){
+                errored = true;
+            }
+        });
+        await waitForTrue(()=>{return errored;},1000);
+        expect(errored).to.be.true;
+    });
+
     function _createFolder(path) {
         return new Promise((resolve, reject)=>{
             fs.mkdir(path, 777, (err)=>{