Skip to content

Conversation

@theseion
Copy link
Contributor

… with dead contexts

Use #currentPC instead of pc to access the PC of the context to prevent errors on dead contexts, where pc is nil.

fixes #18718

… with dead contexts

Use `#currentPC` instead of `pc` to access the PC of the context to prevent errors
on dead contexts, where `pc` is `nil`.

fixes pharo-project#18718
@Ducasse
Copy link
Member

Ducasse commented Oct 18, 2025

Tx Max.
When do you have dead contexts from which you want to access variables.
Because we were thinking about it when we worked on the debug info and revise the complete debug API.

@theseion
Copy link
Contributor Author

theseion commented Oct 18, 2025

Fuel, obviously ;) When you deserialize a context, it will be dead.

Ignore that. I have a test in Fuel that creates a dead context, serializes and deserializes it, and then reads the value of a temporary variable. This used to work but no longer does. It's not a big issue and I could rewrite the test to use a live context instead.

@jecisc jecisc requested a review from guillep October 20, 2025 14:48
@Ducasse
Copy link
Member

Ducasse commented Oct 23, 2025

I think that we can integrate and ask guille to review later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OnlineSourceDebugInfo>>#readVariableNamed:fromContext: cannot deal with dead contexts

2 participants