refactor: updated depencencies regarding prettier (#1307)

* refactor: updated husky and pretty-quick dependencies

and updated to the new config storage model and removed husky and pretty-quick from packages/core, as this should be possible to get triggered from root

* refactor: updated prettier dependency

and removed rules "trailingComma": "es5" as this is the new default

* fix: added missing comma

* refactor: regenerated yarn.lock file

* refactor(husky): made additional necessary changes for the installation

as well as moved husky to the devDependencies, as defined by the software doc itself

* refactor(pinst): remove that solution again

see typicode/husky#884

* refactor(code): integrated prettier feedback

that was enforced like this by eslint

* refactor(husky): updated husky and added pinst

Yarn 2 doesn't support prepare lifecycle script, so husky needs to be installed differently (this doesn't apply to Yarn 1 though)

* Revert "refactor(husky): updated husky and added pinst"

This reverts commit e834b42.

* refactor(husky): updated husky

Co-authored-by: Josef Bredreck <[email protected]>

Author: mfranzke

.husky/.gitignore

@@ -0,0 +1 @@
+_

.husky/pre-commit

@@ -0,0 +1,4 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+npx --no-install pretty-quick --staged

.prettierrc

@@ -1,5 +1,4 @@
 {
   "singleQuote": true,
-  "trailingComma": "es5",
   "endOfLine": "auto"
 }

package.json

@@ -18,11 +18,11 @@
     "eslint-config-prettier": "^6.0.0",
     "eslint-plugin-import": "^2.18.2",
     "eslint-plugin-prettier": "^3.1.0",
-    "prettier": "^1.14.3",
     "lerna": "3.17.0",
-    "pretty-quick": "^1.11.1",
     "auto": "^9.40.5",
-    "@auto-it/released": "^9.40.5"
+    "@auto-it/released": "^9.40.5",
+    "prettier": "^2.2.1",
+    "pretty-quick": "^3.1.0"
   },
   "repository": {
     "type": "git",
@@ -41,7 +41,8 @@
     "publish": "npx lerna publish -m \"[skip travis] chore(release): publish %s\"",
     "postpublish": "auto release",
     "preview:docs": "cd packages/docs && yarn production",
-    "preview:hbs": "cd packages/development-edition-engine-handlebars && yarn pl:starterkit && yarn pl:build"
+    "preview:hbs": "cd packages/development-edition-engine-handlebars && yarn pl:starterkit && yarn pl:build",
+    "prepare": "husky install"
   },
   "nyc": {
     "exclude": [
@@ -50,5 +51,8 @@
       "packages/core/test",
       "packages/live-server"
     ]
+  },
+  "devDependencies": {
+    "husky": "^6.0.0"
   }
 }

packages/cli/package.json

@@ -34,7 +34,7 @@
     "eslint": "4.18.2",
     "eslint-config-prettier": "2.9.0",
     "eslint-plugin-prettier": "2.6.0",
-    "prettier": "1.11.1",
+    "prettier": "2.2.1",
     "proxyquire": "2.1.3",
     "tap": "14.11.0"
   },

packages/core/package.json

@@ -30,10 +30,8 @@
     "eslint-config-prettier": "^6.0.0",
     "eslint-plugin-import": "^2.18.2",
     "eslint-plugin-prettier": "^3.1.0",
-    "husky": "0.14.3",
     "jsdoc-to-markdown": "5.0.1",
-    "prettier": "^1.14.3",
-    "pretty-quick": "^1.11.1",
+    "prettier": "^2.2.1",
     "rewire": "2.5.2",
     "standard-version": "9.1.1",
     "tap": "14.11.0"

packages/core/src/lib/addPattern.js

@@ -2,7 +2,7 @@
 
 const logger = require('./log');
 
-module.exports = function(pattern, patternlab) {
+module.exports = function (pattern, patternlab) {
   //add the link to the global object
   if (!patternlab.data.link) {
     patternlab.data.link = {};

packages/core/src/lib/annotation_exporter.js

@@ -6,7 +6,7 @@ const _ = require('lodash');
 const mp = require('./markdown_parser');
 const logger = require('./log');
 
-const annotations_exporter = function(pl) {
+const annotations_exporter = function (pl) {
   const paths = pl.config.paths;
   let oldAnnotations;
 
@@ -68,7 +68,7 @@ const annotations_exporter = function(pl) {
     //let annotations = annotations;
     const markdown_parser = parser;
 
-    return function(filePath) {
+    return function (filePath) {
       const annotationsMD = fs.readFileSync(path.resolve(filePath), 'utf8');
 
       //take the annotation snippets and split them on our custom delimiter
@@ -110,13 +110,13 @@ const annotations_exporter = function(pl) {
   }
 
   return {
-    gather: function() {
+    gather: function () {
       return gatherAnnotations();
     },
-    gatherJS: function() {
+    gatherJS: function () {
       return parseAnnotationsJS();
     },
-    gatherMD: function() {
+    gatherMD: function () {
       return parseAnnotationsMD();
     },
   };

packages/core/src/lib/buildFooter.js

@@ -13,15 +13,15 @@ let render = require('./render'); //eslint-disable-line prefer-const
  * @param patternPartial - the partial key to build this for, either viewall-patternPartial or a viewall-patternGroup-all
  * @returns A promise which resolves with the HTML
  */
-module.exports = function(patternlab, patternPartial, uikit) {
+module.exports = function (patternlab, patternPartial, uikit) {
   //first render the general footer
   return render(Pattern.createEmpty({ extendedTemplate: uikit.footer }), {
     patternData: JSON.stringify({
       patternPartial: patternPartial,
     }),
     cacheBuster: patternlab.cacheBuster,
   })
-    .then(footerPartial => {
+    .then((footerPartial) => {
       let allFooterData;
       try {
         allFooterData = jsonCopy(
@@ -36,7 +36,7 @@ module.exports = function(patternlab, patternPartial, uikit) {
 
       return render(patternlab.userFoot, allFooterData);
     })
-    .catch(reason => {
+    .catch((reason) => {
       console.log(reason);
       logger.error('Error building buildFooterHTML');
     });

packages/core/src/lib/buildListItems.js

@@ -26,7 +26,7 @@ const items = [
   'twenty',
 ];
 
-module.exports = function(container) {
+module.exports = function (container) {
   //combine all list items into one structure
   const list = [];
   for (const item in container.listitems) {