fix: safer regex

ThisAMJ · ThisAMJ · commit d46748634dad · 2023-02-01T16:28:53.000+11:00
this also limits the protocol to http / https
diff --git a/src/Features/ConfigPlus.cpp b/src/Features/ConfigPlus.cpp
@@ -61,7 +61,7 @@ CON_COMMAND_F(sar_download_file, "sar_download_file <url> <filepath> [directory]
 	}
 	if (!args[1][0] || !args[2][0]) return console->Print(sar_download_file.ThisPtr()->m_pszHelpString);
 
-	std::string domain = std::regex_replace(args[1], std::regex("^.*://([^/?:]+)/?.*$"), "$1");
+	std::string domain = std::regex_replace(args[1], std::regex("^[htps]*://([^/?:]+)/?.*$"), "$1");
 
 	if (!strcmp(domain.c_str(), args[1])) return console->Print("Invalid URL.\n"); // URL is missing protocol. Reject.
 

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ CON_COMMAND_F(sar_download_file, "sar_download_file <url> <filepath> [directory]`
`61`	`61`	`}`
`62`	`62`	`if (!args[1][0] \|\| !args[2][0]) return console->Print(sar_download_file.ThisPtr()->m_pszHelpString);`
`63`	`63`
`64`		`- std::string domain = std::regex_replace(args[1], std::regex("^.://([^/?:]+)/?.$"), "$1");`
	`64`	`+ std::string domain = std::regex_replace(args[1], std::regex("^[htps]://([^/?:]+)/?.$"), "$1");`
`65`	`65`
`66`	`66`	`if (!strcmp(domain.c_str(), args[1])) return console->Print("Invalid URL.\n"); // URL is missing protocol. Reject.`
`67`	`67`