Skip to content

IndeterminateProgressBar max_position in constructor does not reflect bar_width change #152

Description

@hofbauerc

Hello,

During the usage of the IndeterminateProgressBar I found an issue regarding the max_progress. This is only calculated in the constructor. This leads to the issue if you want to change the bar_width after the constructor that the lead is moving outside the visualized area. E.g. if I define bar_width 50 after the constructor then it moves to about 100 depending on lead size.

max_progress_ = get_value<details::ProgressBarOption::bar_width>() -

It would be better to calculate it once on the first tick() call.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions