-
Notifications
You must be signed in to change notification settings - Fork 267
Description
Since PR #1010, multiple single poll requests in series are limited to one request per second, making Javascript toolkits like the UpMiiGo ECU plugin unusably slow or causing crashes.
Since PR #1012, the VWTP protocol is broken.
Examples + Logs, all with the same ECU scans (querying HW & SW info, Coding, Subroutines, DTCs etc.):
a) Pre-bug normal/expected behaviour; HEAD at bd4e719 Merge pull request #1008 from frogonwheels/poller-task-fix:
- Scanning the ISOTP ECU takes ~1 second, with complete & correct results
- Scanning the VWTP ECU takes ~5 seconds, with complete & correct results
pollerbug-251101-scanlog-a.txt
b) Slowdown of all single polls; HEAD at b125dfe Merge pull request #1010 from frogonwheels/fix-obey-throttle:
- Scanning the ISOTP ECU takes ~20 seconds, still complete & correct results
- Scanning the VWTP ECU takes ~35 seconds, still complete & correct results
pollerbug-251101-scanlog-b.txt
c) Partial ISOTP failure + complete VWTP failure; HEAD at 53713d9 Merge pull request #1012 from frogonwheels/fix-shutdown
- Scanning the ISOTP ECU takes ~20 seconds, incomplete results (some queries failed)
- Scannning tht VWTP ECU fails within 1 second with
ERROR: Login failed: Timeout waiting for poller/response
pollerbug-251101-scanlog-c.txt
Meanwhile (current master HEAD) ISOTP again delivers complete results, but still takes more than 20 seconds, VWTP still is totally broken.
@frogonwheels Michael, any idea? It seems single polls now also are throttled, which may be wrong in the first place. If they should be throttled, the API needs some method to control default throttling from JS. Throttling doesn't seem to be the VWTP issue though. Sorry this hasn't been detected earlier, I only use the ECU toolkit about once a year to check for annual service and retrieve DTCs.
The ECU toolkit's scan method is here:
https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/blob/master/plugin/v-vweup/ecutoolkit/xvu-ecu.js#L441