Adding support for removing features

Author: richardfullmer

Controller/DefaultController.php

@@ -143,6 +143,19 @@ public function deactivateUserAction($feature, $id)
         return new RedirectResponse($this->container->get('router')->generate('opensoft_rollout'));
     }
 
+    /**
+     * @param  string           $feature
+     * @return RedirectResponse
+     */
+    public function removeAction($feature)
+    {
+        $this->getRollout()->remove($feature);
+
+        $this->addFlash('info', sprintf("Feature '%s' was removed from rollout.", $feature));
+
+        return new RedirectResponse($this->container->get('router')->generate('opensoft_rollout'));
+    }
+
     /**
      * @return Rollout
      */

README.md

@@ -127,6 +127,8 @@ class AcmeEmployeeGroupDefinition implements GroupDefinitionInterface
 
 Implement a custom storage solution.
 
+**Note:** The rollout `StorageInterface` [changed](https://github.com/opensoft/rollout/releases/tag/2.0.0) in version `2.0.0`.
+
 ```php
 <?php
 
@@ -151,6 +153,15 @@ class MyStorage implements StorageInterface
     {
         // implement set
     }
+
+    /**
+     * @param string $key
+     * @since 2.0.0
+     */
+    public function remove($key)
+    {
+        // implement remove
+    }
 }
 ```
 

Resources/config/routing.yml

@@ -43,3 +43,8 @@ opensoft_rollout_feature_deactivate_user:
     path: /{feature}/deactivate-user/{id}
     defaults:
         _controller: OpensoftRolloutBundle:Default:deactivateUser
+
+opensoft_rollout_feature_remove:
+    path: /{feature}/remove
+    defaults:
+        _controller: OpensoftRolloutBundle:Default:remove

Resources/views/Default/index.html.twig

@@ -148,12 +148,17 @@
                     </ul>
                 </td>
                 <td>
+                    {% block rollout_feature_actions %}
                     <a class="btn btn-default btn-sm" href="{{ path('opensoft_rollout_feature_activate', {'feature': feature.name }) }}" title="Globally activate this feature">
                         activate
                     </a>
                     <a class="btn btn-default btn-sm" href="{{ path('opensoft_rollout_feature_deactivate', {'feature': feature.name }) }}" title="Globally deactivate this feature">
                         deactivate
                     </a>
+                    <a class="btn btn-default btn-sm" href="{{ path('opensoft_rollout_feature_remove', {'feature': feature.name }) }}" title="Globally remove this feature">
+                        remove
+                    </a>
+                    {% endblock %}
                 </td>
             </tr>
 

Storage/Doctrine/DoctrineORMStorage.php

@@ -69,6 +69,18 @@ public function set($key, $value)
         $feature->setSettings($value);
 
         $this->em->persist($feature);
-        $this->em->flush();
+        $this->em->flush($feature);
+    }
+
+    /**
+     * @param string $key
+     */
+    public function remove($key)
+    {
+        $feature = $this->repository->findOneBy(array('name' => $key));
+        if ($feature) {
+            $this->em->remove($feature);
+            $this->em->flush($feature);
+        }
     }
 }

composer.json

@@ -11,7 +11,7 @@
     "require": {
         "php": ">=5.3",
         "symfony/framework-bundle": "~2.1",
-        "opensoft/rollout": "~1.0"
+        "opensoft/rollout": "~2.0"
     },
     "require-dev": {
         "phpunit/phpunit": "*"