Fix GradioUI system prompt #2669
Conversation
On the GradioUI the system prompt displayed is *always* using the default system prompt, which is problematic when running the service with a custom system prompt (`system_prompt_path`) and allowing overriding it (`enable_system_prompt_override: true`). With this simple patch we default to the configured system prompt on the GradioUI and only use the default system prompt if we don't have it configured.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Akrog
force-pushed
the
ui-system-prompt
branch
from
94a20d1 to
cd38b84
Compare
|
/retest-required |
|
@Akrog: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Description
On the GradioUI the system prompt displayed is always using the default system prompt, which is problematic when running the service with a custom system prompt (
system_prompt_path) and allowing overriding it (enable_system_prompt_override: true).With this simple patch we default to the configured system prompt on the GradioUI and only use the default system prompt if we don't have it configured.
Type of change
Checklist before requesting a review
Testing