OCPBUGS-65859: Fix set-hostname dependency for interactive console services #10118
Conversation
…rvices The agent-interactive-console and agent-interactive-console-serial@ services should have consistent Before/After edges since only one runs on each system (depending on whether there is a graphical console). Previously, set-hostname.service had a Before= dependency on agent-interactive-console.service only, which created an edge in the systemd diagrams from set-hostname to agent-interactive-console but not to agent-interactive-console-serial@. This fixes the inconsistency by: - Adding set-hostname.service to the After= directive in both console services - Removing the redundant Before= directive from set-hostname.service Both services now define the dependency consistently in the same direction. Assisted-by: Claude Code
openshift-ci-robot
added
jira/severity-low
|
@zaneb: This pull request references Jira Issue OCPBUGS-65859, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The agent-interactive-console and agent-interactive-console-serial@ services should have consistent Before/After edges. Previously, agent-auth-token-status.service had agent-interactive-console.service in its After= directive, but there was no corresponding dependency for the serial console variant. This adds agent-auth-token-status.service to the Before= directive in both console services, and removes the now-redundant After= directive from agent-auth-token-status.service, so both services define the dependency consistently in the same direction. Assisted-by: Claude Code
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@zaneb: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@zaneb: This pull request references Jira Issue OCPBUGS-65859, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @mhanss |
5 participants
The agent-interactive-console and agent-interactive-console-serial@ services should have consistent Before/After edges since only one runs on each system (depending on whether there is a graphical console).
Previously, set-hostname.service had a Before= dependency on agent-interactive-console.service only, which created an edge in the systemd diagrams from set-hostname to agent-interactive-console but not to agent-interactive-console-serial@.
This fixes the inconsistency by:
Both services now define the dependency consistently in the same direction.
(This is the first bug detected by our new autogenerated dependency diagrams!)