Update fake clientsets to NewClientset

Author: JoelSpeed

lib/resourceapply/security_test.go

@@ -154,7 +154,7 @@ func TestApplySecurityContextConstraintsv1(t *testing.T) {
 	}
 	for _, tc := range tests {
 		t.Run(tc.name, func(t *testing.T) {
-			newClient := securityfake.NewSimpleClientset()
+			newClient := securityfake.NewClientset()
 			// We cannot simply initialize the client because initialization is broken for SCC
 			// https://github.com/openshift/client-go/issues/244
 			if tc.existing != nil {

pkg/cvo/cvo_test.go

@@ -503,7 +503,7 @@ func TestOperator_sync(t *testing.T) {
 				},
 				namespace: "test",
 				name:      "default",
-				client: fake.NewSimpleClientset(
+				client: fake.NewClientset(
 					&configv1.ClusterVersion{
 						ObjectMeta: metav1.ObjectMeta{
 							Name: "default",
@@ -560,7 +560,7 @@ func TestOperator_sync(t *testing.T) {
 				},
 				namespace: "test",
 				name:      "default",
-				client: fake.NewSimpleClientset(
+				client: fake.NewClientset(
 					&configv1.ClusterVersion{
 						ObjectMeta: metav1.ObjectMeta{
 							Name: "default",
@@ -4230,7 +4230,7 @@ func Test_loadReleaseVerifierFromConfigMap(t *testing.T) {
 			tt.update.Manifests = ms
 		}
 		t.Run(tt.name, func(t *testing.T) {
-			f := kfake.NewSimpleClientset()
+			f := kfake.NewClientset()
 			got, store, err := loadConfigMapVerifierDataFromUpdate(tt.update, sigstore.DefaultClient, f.CoreV1(), &serial.Store{})
 			if err == nil {
 				if tt.expectedError != "" {

pkg/featuregates/featurechangestopper_test.go

@@ -99,7 +99,7 @@ func TestTechPreviewChangeStopper(t *testing.T) {
 				tt.startingCvoFeatureGates = CvoGates{unknownVersion: true}
 			}
 
-			client := fakeconfigv1client.NewSimpleClientset(fg)
+			client := fakeconfigv1client.NewClientset(fg)
 
 			informerFactory := configv1informer.NewSharedInformerFactory(client, 0)
 			c, err := NewChangeStopper(informerFactory.Config().V1().FeatureGates(), tt.startingRequiredFeatureSet, tt.startingCvoFeatureGates)