OCPBUGS-65469: Add ClusterRole to ClusterOperator relatedObjects #429
Conversation
This adds the cloud-controller-manager ClusterRole to the ClusterOperator's relatedObjects to ensure it's collected by oc adm inspect and must-gather for debugging purposes. The name field is set to the specific ClusterRole name since the operator manages a single ClusterRole resource. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
openshift-ci-robot
added
jira/severity-low
|
@RadekManak: This pull request references Jira Issue OCPBUGS-65469, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@RadekManak: This pull request references Jira Issue OCPBUGS-65469, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| {Resource: "namespaces", Name: defaultManagementNamespace}, | ||
| {Group: configv1.GroupName, Resource: "clusteroperators", Name: clusterOperatorName}, | ||
| {Resource: "namespaces", Name: r.ManagedNamespace}, | ||
| {Group: "rbac.authorization.k8s.io", Resource: "clusterroles", Name: clusterOperatorName}, |
There was a problem hiding this comment.
Is a ClusterRole all you need? I'd expect you'd also need a ClusterRoleBinding that attaches that role to a ServiceAccount? And maybe other things?
There was a problem hiding this comment.
This looked like a trivial issue. I skimmed the issue a missed that this requires consideration of what to include. I marked the PR as draft and will revisit this next week.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
3 participants
This adds the cloud-controller-manager ClusterRole to the ClusterOperator's relatedObjects to ensure it's collected by oc adm inspect and must-gather for debugging purposes.
The name field is set to the specific ClusterRole name since the operator manages a single ClusterRole resource.
🤖 Generated with Claude Code