-
Notifications
You must be signed in to change notification settings - Fork 343
New integration tests for Dashboards multi-tenancy #5753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nils Bandener <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5753 +/- ##
==========================================
+ Coverage 73.12% 73.19% +0.06%
==========================================
Files 435 435
Lines 26665 26665
Branches 3999 3999
==========================================
+ Hits 19499 19517 +18
+ Misses 5249 5240 -9
+ Partials 1917 1908 -9 🚀 New features to boost your workflow:
|
Signed-off-by: Nils Bandener <[email protected]>
DarshitChanpura
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @nibix . Changes lgtm. Left a couple of clarifying comments.
...ionTest/java/org/opensearch/security/privileges/int_tests/DashboardMultiTenancyIntTests.java
Show resolved
Hide resolved
...ionTest/java/org/opensearch/security/privileges/int_tests/DashboardMultiTenancyIntTests.java
Show resolved
Hide resolved
|
@nibix thank you for adding more tests case within this repo for this. I think this repo is lacking is this area. |
...ionTest/java/org/opensearch/security/privileges/int_tests/DashboardMultiTenancyIntTests.java
Show resolved
Hide resolved
|
@DarshitChanpura could you have another look at this, please? |
4530c82
into
opensearch-project:main
Description
This introduces integration tests for Dashboards multi-tenancy based on the concept that is also used by the other newly authorization integration tests.
This is in preparation for the "Improved index resolution" project #5399 and allows us to test the different privilege evaluation implementations and compare their behavior.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.