Skip to content

Conversation

@nibix
Copy link
Collaborator

@nibix nibix commented Oct 28, 2025

Description

This introduces integration tests for Dashboards multi-tenancy based on the concept that is also used by the other newly authorization integration tests.

This is in preparation for the "Improved index resolution" project #5399 and allows us to test the different privilege evaluation implementations and compare their behavior.

Check List

  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.19%. Comparing base (da520a0) to head (634e80f).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5753      +/-   ##
==========================================
+ Coverage   73.12%   73.19%   +0.06%     
==========================================
  Files         435      435              
  Lines       26665    26665              
  Branches     3999     3999              
==========================================
+ Hits        19499    19517      +18     
+ Misses       5249     5240       -9     
+ Partials     1917     1908       -9     

see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Nils Bandener <[email protected]>
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nibix . Changes lgtm. Left a couple of clarifying comments.

@cwperks
Copy link
Member

cwperks commented Nov 4, 2025

@nibix thank you for adding more tests case within this repo for this. I think this repo is lacking is this area.

@nibix
Copy link
Collaborator Author

nibix commented Nov 10, 2025

@DarshitChanpura could you have another look at this, please?

@DarshitChanpura DarshitChanpura merged commit 4530c82 into opensearch-project:main Nov 11, 2025
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants