Dependency resolution failure markers linger after sequential ChangeDependency calls that bring file into correct state
#5814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om.xml` when you run two recipes in a row that eventually make the appropriate change
steve-aom-elliott
added
bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
timtebeek
reviewed
Jul 29, 2025
Comment on lines
+1684
to
+1686
| spec -> spec.recipes( | ||
| new ChangeDependencyGroupIdAndArtifactId("io.swagger", "swagger-annotations", "io.swagger.core.v3", null, "2.2.x", null, null, null), | ||
| new ChangeDependencyGroupIdAndArtifactId("io.swagger", "swagger-models", "io.swagger.core.v3", null, "2.2.x", null, null, null) |
There was a problem hiding this comment.
Heads up that this is also explored in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added a test showing the failure markers when running two
ChangeDependencyrecipes for dependencies relying on the samepom.xmlproperty for their version number. I suppose the problem is that if you run the recipes one after the other, although it reaches the correct state, it's going to still say in the file that there were resolution failures and that would be in the diff.Checklist