Skip to content

optionally use POST insetad of GET for WMSGetFeatureInfo - trac ticket 3357 #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

optionally use POST insetad of GET for WMSGetFeatureInfo - trac ticket 3357 #1507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 45 additions & 7 deletions lib/OpenLayers/Control/WMSGetFeatureInfo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,13 @@ OpenLayers.Control.WMSGetFeatureInfo = OpenLayers.Class(OpenLayers.Control, {
*/
hoverRequest: null,

/**
* APIProperty: usePOST
* {Boolean} true if the GetFeatureInfo request are done with POST requests
* instead of GET, defaults to false.
*/
usePOST: false,

/**
* APIProperty: events
* {<OpenLayers.Events>} Events instance for listeners and triggering
Expand Down Expand Up @@ -435,7 +442,7 @@ OpenLayers.Control.WMSGetFeatureInfo = OpenLayers.Class(OpenLayers.Control, {
if(this.drillDown === false) {
var wmsOptions = this.buildWMSOptions(this.url, layers,
clickPosition, layers[0].params.FORMAT);
var request = OpenLayers.Request.GET(wmsOptions);
var request = this.doRequest(clickPosition, options, wmsOptions);

if (options.hover === true) {
this.hoverRequest = request;
Expand All @@ -448,7 +455,6 @@ OpenLayers.Control.WMSGetFeatureInfo = OpenLayers.Class(OpenLayers.Control, {
var services = {}, url;
for(var i=0, len=layers.length; i<len; i++) {
var layer = layers[i];
var service, found = false;
url = OpenLayers.Util.isArray(layer.url) ? layer.url[0] : layer.url;
if(url in services) {
services[url].push(layer);
Expand All @@ -457,16 +463,48 @@ OpenLayers.Control.WMSGetFeatureInfo = OpenLayers.Class(OpenLayers.Control, {
services[url] = [layer];
}
}
var layers;
for (var url in services) {
layers = services[url];
var wmsOptions = this.buildWMSOptions(url, layers,
for (var urlService in services) {
layers = services[urlService];
var wmsOptions2 = this.buildWMSOptions(urlService, layers,
clickPosition, layers[0].params.FORMAT);
OpenLayers.Request.GET(wmsOptions);
this.doRequest(clickPosition, options, wmsOptions2);
}
}
},

/**
* Method: doRequest
* Sends a GetFeatureInfo request to the WMS depending on option usePOST
*
* Parameters:
* clickPosition - {<OpenLayers.Pixel>} The position on the map where the
* mouse event occurred.
* options - {Object} additional options for this method.
* wmsOptions - {Array({Object})} with the relevant WMS options for the
* GetFeatureInfo request gotten by buildWMSOptions.
*/
doRequest: function (clickPosition, options, wmsOptions) {
var usePOST = (options.usePOST !== undefined) ?
options.usePOST : this.usePOST;
var request;
if (usePOST) {
var headers = wmsOptions.headers || {};
headers["Content-Type"] = "application/x-www-form-urlencoded";
request = OpenLayers.Request.POST({
url: wmsOptions.url,
callback: function (request) {
this.handleResponse(clickPosition, request, wmsOptions.url);
},
data: OpenLayers.Util.getParameterString(wmsOptions.params),
headers: headers,
scope: this
});
} else {
request = OpenLayers.Request.GET(wmsOptions);
}
return request;
},

/**
* Method: triggerGetFeatureInfo
* Trigger the getfeatureinfo event when all is done
Expand Down