8372844: Improve usage of test/jdk/java/text/testlib/TestUtils.java locale methods

[justin-curtis-lu]

This PR updates the call sites of TestUtils::usesGregorianCalendar, TestUtils::usesAsciiDigits, and TestUtils::hasSpecialVariant to use Assumptions to properly abort the test.

The existing usage of these methods involve printing to output and returning when locale conditions are not met. Some of these tests do lots of printing, so identifying when a test is skipped due to inadequate locale conditions may not be obvious. Instead of simply printing to output, it would be better for test diagnostics to abort the tests, which is easy to identify in the Jtreg output. E.g.

[ JUnit Tests: found 1189, started 1189, succeeded 1185, failed 0, aborted 4, skipped 0]

As a result of this change, Bug4407042, Bug4845901, Bug6530336, and LocaleCategory were converted to JUnit based tests. (I could have decided to throw jtreg.SkippedException for those tests, but decided to just convert as well.)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372844: Improve usage of test/jdk/java/text/testlib/TestUtils.java locale methods (Bug - P4)

Reviewers

• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28590/head:pull/28590
$ git checkout pull/28590

Update a local copy of the PR:
$ git checkout pull/28590
$ git pull https://git.openjdk.org/jdk.git pull/28590/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28590

View PR using the GUI difftool:
$ git pr show -t 28590

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28590.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372844: Improve usage of test/jdk/java/text/testlib/TestUtils.java locale methods

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 152 new commits pushed to the master branch:

• c55287d: 8370890: Start of release updates for JDK 27
• 45dcc0e: 8371914: PNG defines in CFLAGS can cause compilation errors with external libpng
• 2735140: 8370939: C2: SIGSEGV in SafePointNode::verify_input when processing MH call from Compile::process_late_inline_calls_no_inline()
• ... and 149 more: https://git.openjdk.org/jdk/compare/c028369dcb0a677541b89117b0800125bc7c6c33...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@justin-curtis-lu The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ed9f1ba7)
• 00: Full (6de6b7fa)

[naotoj]

Looks good. A couple of comments follow

[naotoj]

Specifying othervm is safer, as the test sets the default time zone

[naotoj]

Could use non-escaped strings

[naotoj]

LGTM

[justin-curtis-lu]

/integrate

[openjdk]

Going to push as commit c7aa103.
Since your change was applied there have been 152 commits pushed to the master branch:

• c55287d: 8370890: Start of release updates for JDK 27
• 45dcc0e: 8371914: PNG defines in CFLAGS can cause compilation errors with external libpng
• 2735140: 8370939: C2: SIGSEGV in SafePointNode::verify_input when processing MH call from Compile::process_late_inline_calls_no_inline()
• ... and 149 more: https://git.openjdk.org/jdk/compare/c028369dcb0a677541b89117b0800125bc7c6c33...master

Your commit was automatically rebased without conflicts.

[openjdk]

@justin-curtis-lu Pushed as commit c7aa103.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.