-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8372703: Test compiler/arguments/TestCodeEntryAlignment.java failed: assert(allocates2(pc)) failed: not in CodeBuffer memory #28588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back vpaprotski! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@vpaprotsk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
mhaessig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this, @vpaprotsk. Please also remove the problem listing of the compiler/arguments/TestCodeEntryAlignment.java:
jdk/test/hotspot/jtreg/ProblemList.txt
Line 82 in 84ffe87
| compiler/arguments/TestCodeEntryAlignment.java 8372703 generic-x64 |
Meanwhile, I will run testing on our side and report back with the results.
dafedafe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vpaprotsk for fixing this. Looks good to me (if tests are OK).
| do_arch_entry, \ | ||
| do_arch_entry_init) \ | ||
| do_arch_blob(compiler, 109000 WINDOWS_ONLY(+2000)) \ | ||
| do_arch_blob(compiler, 120000 WINDOWS_ONLY(+2000)) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if there are any reason for this value (apart that it is enough for the test to pass. I just noticed that it has been increased already in the past).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assert was suggesting 119k (and change..) so I rounded slightly up. I was going to ask (i.e. @TobiHartmann ?) if thats enough..
(Similarly, I am concerned that I am contributing to a larger JVM footprint, with my changes.. but I suppose 11k is comparatively insignificant in the grand scheme of things...)
Thanks for the review!
Done. Thanks for the tests @mhaessig let me know how it goes |
mhaessig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my comments. Testing passed up to tier6.
Requires a Broadwell machine, but was able to reproduce with an emulator:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28588/head:pull/28588$ git checkout pull/28588Update a local copy of the PR:
$ git checkout pull/28588$ git pull https://git.openjdk.org/jdk.git pull/28588/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28588View PR using the GUI difftool:
$ git pr show -t 28588Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28588.diff
Using Webrev
Link to Webrev Comment