Skip to content

Conversation

@vpaprotsk
Copy link
Contributor

@vpaprotsk vpaprotsk commented Dec 1, 2025

Requires a Broadwell machine, but was able to reproduce with an emulator:

~/sde-external-9.58.0-2025-06-16-lin/sde64 -follow-subprocess -bdw -- ./build/linux-x86_64-server-fastdebug/images/jdk/bin/java  -XX:-UseMulAddIntrinsic -XX:+UseDilithiumIntrinsics -XX:+UnlockExperimentalVMOptions -XX:CodeCacheSegmentSi
ze=1024 -XX:CodeEntryAlignment=1024 -cp build/linux-x86_64-server-fastdebug/support/test/lib/test-lib.jar test/hotspot/jtreg/compiler/arguments/TestCodeEntryAlignment.java run

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372703: Test compiler/arguments/TestCodeEntryAlignment.java failed: assert(allocates2(pc)) failed: not in CodeBuffer memory (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28588/head:pull/28588
$ git checkout pull/28588

Update a local copy of the PR:
$ git checkout pull/28588
$ git pull https://git.openjdk.org/jdk.git pull/28588/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28588

View PR using the GUI difftool:
$ git pr show -t 28588

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28588.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2025

👋 Welcome back vpaprotski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Dec 1, 2025

@vpaprotsk The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 1, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 1, 2025

Webrevs

Copy link
Contributor

@mhaessig mhaessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this, @vpaprotsk. Please also remove the problem listing of the compiler/arguments/TestCodeEntryAlignment.java:

compiler/arguments/TestCodeEntryAlignment.java 8372703 generic-x64

Meanwhile, I will run testing on our side and report back with the results.

Copy link
Contributor

@dafedafe dafedafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vpaprotsk for fixing this. Looks good to me (if tests are OK).

do_arch_entry, \
do_arch_entry_init) \
do_arch_blob(compiler, 109000 WINDOWS_ONLY(+2000)) \
do_arch_blob(compiler, 120000 WINDOWS_ONLY(+2000)) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if there are any reason for this value (apart that it is enough for the test to pass. I just noticed that it has been increased already in the past).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assert was suggesting 119k (and change..) so I rounded slightly up. I was going to ask (i.e. @TobiHartmann ?) if thats enough..

(Similarly, I am concerned that I am contributing to a larger JVM footprint, with my changes.. but I suppose 11k is comparatively insignificant in the grand scheme of things...)

Thanks for the review!

@vpaprotsk
Copy link
Contributor Author

compiler/arguments/TestCodeEntryAlignment.java 8372703 generic-x64

Meanwhile, I will run testing on our side and report back with the results.

Done. Thanks for the tests @mhaessig let me know how it goes

Copy link
Contributor

@mhaessig mhaessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comments. Testing passed up to tier6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants