Skip to content

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Dec 1, 2025

On changing LookAndFeel of JTabbedPane, it resets the focus of the child tabs to starting child tab.
That is, if a JTabbedPane has say 10 tabs and we select the 10th tab and then we change the L&F, the focus is shifted to Tab0 even though the selected tab is still at 10th tab.

This is because when we switch L&F, installUI will reset the focusIndex

public void installUI(JComponent c) {
this.tabPane = (JTabbedPane)c;
calculatedBaseline = false;
rolloverTabIndex = -1;
focusIndex = -1;

which needs to set the proper focus by calling scrollRectToVisible to selected tab which is done in this fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-4459231: Focus of JTabbedPane(with Scrollable tablayout) changes on change in LookAndFeel (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28571/head:pull/28571
$ git checkout pull/28571

Update a local copy of the PR:
$ git checkout pull/28571
$ git pull https://git.openjdk.org/jdk.git pull/28571/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28571

View PR using the GUI difftool:
$ git pr show -t 28571

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28571.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2025

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Dec 1, 2025

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 1, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 1, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant