4459231: Focus of JTabbedPane(with Scrollable tablayout) changes on change in LookAndFeel #28571
+119
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On changing LookAndFeel of JTabbedPane, it resets the focus of the child tabs to starting child tab.
That is, if a JTabbedPane has say 10 tabs and we select the 10th tab and then we change the L&F, the focus is shifted to Tab0 even though the selected tab is still at 10th tab.
This is because when we switch L&F,
installUIwill reset thefocusIndexjdk/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java
Lines 285 to 290 in 3481252
which needs to set the proper focus by calling
scrollRectToVisibleto selected tab which is done in this fix.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28571/head:pull/28571$ git checkout pull/28571Update a local copy of the PR:
$ git checkout pull/28571$ git pull https://git.openjdk.org/jdk.git pull/28571/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28571View PR using the GUI difftool:
$ git pr show -t 28571Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28571.diff
Using Webrev
Link to Webrev Comment