Skip to content

Conversation

@egahlin
Copy link
Member

@egahlin egahlin commented Oct 9, 2025

Could I get a review of a PR that removes dead code?

Testing: test/jdk/jdk/jfr

To ensure the code is not used, I added Thread.sleep(10000000) to the lambda, but no tests timed out.

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8369510: JFR: Remove flush handler from Dispatcher lookup (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27733/head:pull/27733
$ git checkout pull/27733

Update a local copy of the PR:
$ git checkout pull/27733
$ git pull https://git.openjdk.org/jdk.git pull/27733/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27733

View PR using the GUI difftool:
$ git pr show -t 27733

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27733.diff

Using Webrev

Link to Webrev Comment

@egahlin egahlin marked this pull request as ready for review October 9, 2025 15:40
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 9, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 9, 2025

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369510: JFR: Remove flush handler from Dispatcher lookup

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Oct 9, 2025

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2025
@egahlin
Copy link
Member Author

egahlin commented Oct 13, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 13, 2025

Going to push as commit 1668162.
Since your change was applied there have been 45 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 13, 2025
@openjdk openjdk bot closed this Oct 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2025
@openjdk
Copy link

openjdk bot commented Oct 13, 2025

@egahlin Pushed as commit 1668162.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-jfr [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants