7903889: jcstress: document used properties (and env variables) #156
Conversation
|
👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
judovana
force-pushed
the
propertiesToHelp
branch
from
cd69e2c to
1761d67
Compare
|
@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
judovana
changed the title
Webrevs
|
judovana
force-pushed
the
propertiesToHelp
branch
from
4303a35 to
c67cbf4
Compare
|
@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
judovana
force-pushed
the
propertiesToHelp
branch
from
a08fdfa to
cf4d412
Compare
|
@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
...keep live... |
|
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
More is coming! |
|
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
I still have faith! |
|
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
loosing faith:( |
|
../live.. |
|
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
Faith restored! |
Known properties unifed in one class and printed in verbose help: The verbose help can be removed, the individual properties with defaults can be wrapped to its class. Even the OptionSpec and OptionFormatter can be used if needed
judovana
force-pushed
the
propertiesToHelp
branch
from
cf4d412 to
9702a5b
Compare
|
@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
faith restored |
|
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
Is there hope? |
|
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
Loosing the faith... |
|
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
Loosing the faith... |
|
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
judovana
changed the title
openjdk
bot
changed the title
|
@JarvisCraft feel free to eyball-) |
1 participant
The purpose of this PR is to move properties and properties based initializations to single place, and to document them, and to enable printing the listing with the documentation via help.
No Env. vars were found.
The verbose help can be removed, the individual properties with defaults are wrapped to its class. The OptionSpec and OptionFormatter can be used if needed
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/156/head:pull/156$ git checkout pull/156Update a local copy of the PR:
$ git checkout pull/156$ git pull https://git.openjdk.org/jcstress.git pull/156/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 156View PR using the GUI difftool:
$ git pr show -t 156Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/156.diff
Using Webrev
Link to Webrev Comment