Skip to content

Conversation

@asajjad2
Copy link

What are the relevant tickets?

#9097

Description (What does it do?)

Time fields in Schedule settings rely on react-datepicker’s time-only popover, which only responds to mouse input. ArrowUp/ArrowDown do nothing, so keyboard and screen-reader users can’t adjust the time.

This PR intercept ArrowUp/ArrowDown in DatepickerControl when it’s used as a time picker, parse the current value, and advance/rewind by 30-minute steps. Let react-datepicker update the highlighted entry and scroll the popover into view.

Screencast

Screen.Recording.2025-11-11.at.3.38.55.PM.mov

How can this be tested?

  1. On schedule page, focus a time field and press ArrowDown/ArrowUp—time should shift ±30 minutes, and the highlighted row stays visible.
  2. Verify mouse interactions still work as before.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 11, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @asajjad2!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 82.69231% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.72%. Comparing base (3089d0b) to head (3b6bcc3).
⚠️ Report is 1227 commits behind head on master.

Files with missing lines Patch % Lines
...c/generic/datepicker-control/DatepickerControl.jsx 82.69% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2613      +/-   ##
==========================================
+ Coverage   93.02%   94.72%   +1.69%     
==========================================
  Files         756     1233     +477     
  Lines       13708    27759   +14051     
  Branches     2961     6280    +3319     
==========================================
+ Hits        12752    26294   +13542     
- Misses        920     1390     +470     
- Partials       36       75      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bradenmacdonald
Copy link
Contributor

Thanks, this looks nice! Please let me know when it's ready for review.

Also, will this work with v8 ? #2572
Ideally we could add this functionality and do the version bump at the same time.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

3 participants