Add count to UI #725
Draft
Add count to UI #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccalluc
commented
Nov 19, 2025
|
|
||
| columns_icon = icon_svg("table-columns") | ||
| groups_icon = icon_svg("table") | ||
| row_counts_icon = icon_svg("hashtag") |
Contributor
Author
There was a problem hiding this comment.
If this should be it's own panel, do any of the other icons seem better?
mccalluc
commented
Nov 19, 2025
| DP Statistics for `data_col`, grouped by `grouping_col`, without counts | ||
| >>> print(plan.to_stem()) | ||
| dp_statistics_for_data_col_grouped_by_grouping_col | ||
| dp_statistics_for_data_col_grouped_by_grouping_col_without_counts |
Contributor
Author
There was a problem hiding this comment.
Is the without_counts too much?
Contributor
Author
|
Suggestion from Ellen: Always do count, and explain in the notebook that it is optional. Less UI clutter, and simpler code generation, and probably less confusing to users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, just want to allow counts to be manually turned on. After this, will turn on counts in the AnalysisPlan (even if not selected in UI) when a mean is requested, so we only need to release the DP count once.
For reviewer:
If anything feels sketchy here, one possibility would be to keep a lot of the tooling changes, which are unequivocally improvements, and then try a different approach for the count analysis.