fix(pastebin): fix scrollTo on public links, show anchor links everywhere

- Include folder fileId in anchor URLs so AppWrapper's
  replaceInvalidFileRoute preserves scrollTo where possible
- Show anchor links on public link views (fall back to current URL)
- Read scrollTo from window.location.search before AppWrapper can
  rewrite the URL (public link resolution may change the fileId,
  causing replaceInvalidFileRoute to strip other query params)
- Add e2e test that opens a public link with scrollTo and verifies
  the target file is scrolled into view

Author: dschmidt

packages/web-app-pastebin/src/View.vue

@@ -71,6 +71,7 @@
             :resource="file"
             :space="space"
             :share-url="shareUrl"
+            :folder-file-id="resource.fileId"
             @loaded="onFileLoaded"
           />
         </div>
@@ -80,7 +81,7 @@
 </template>
 
 <script setup lang="ts">
-import { computed, nextTick, onMounted, ref, unref, watch } from 'vue'
+import { computed, nextTick, onMounted, ref, watch } from 'vue'
 import {
   FolderResource,
   LinkShare,
@@ -91,11 +92,9 @@ import {
   urlJoin
 } from '@opencloud-eu/web-client'
 import {
-  queryItemAsString,
   useClientService,
   useConfigStore,
   useResourcesStore,
-  useRouteQuery,
   useRouter,
   useSharesStore,
   contextRouteNameKey
@@ -192,20 +191,18 @@ const deletePastebin = () => {
   })
 }
 
-const scrollToQuery = useRouteQuery('scrollTo')
-const scrollTarget = computed(() => queryItemAsString(unref(scrollToQuery)))
+// Read scrollTo before AppWrapper's replaceInvalidFileRoute can strip it from the URL
+const initialScrollTarget = new URLSearchParams(window.location.search).get('scrollTo') || ''
 const filesLoadedCount = ref(0)
 const totalFiles = computed(() => folderResources.value.filter((r) => !r.isFolder).length)
 
 const onFileLoaded = async () => {
   filesLoadedCount.value++
   if (filesLoadedCount.value < totalFiles.value) return
-
-  const target = scrollTarget.value
-  if (!target) return
+  if (!initialScrollTarget) return
 
   await nextTick()
-  scrollToFile(target)
+  scrollToFile(initialScrollTarget)
 }
 
 const loadShares = async (folderResource: Resource) => {

packages/web-app-pastebin/src/components/PastebinFile.vue

@@ -108,6 +108,7 @@ const props = defineProps<{
   resource: Resource
   space: SpaceResource
   shareUrl?: string
+  folderFileId?: string
 }>()
 
 const emit = defineEmits<{ loaded: [] }>()
@@ -117,9 +118,16 @@ const clientService = useClientService()
 const { copy, copied } = useClipboard({ legacy: true, copiedDuring: 1500 })
 
 const anchorHref = computed(() => {
-  if (!props.shareUrl) return ''
-  const url = new URL(props.shareUrl)
+  // Use the share URL when available (authenticated view), fall back to the current URL
+  // so anchor links also work on public link views
+  const base = props.shareUrl || window.location.href
+  const url = new URL(base)
   url.searchParams.set('scrollTo', props.resource.name)
+  // fileId of the .ocpb folder is needed so AppWrapper's replaceInvalidFileRoute
+  // doesn't strip scrollTo when rewriting the URL
+  if (props.folderFileId) {
+    url.searchParams.set('fileId', props.folderFileId)
+  }
   return url.toString()
 })
 

packages/web-app-pastebin/tests/e2e/pastebin.spec.ts

@@ -316,6 +316,42 @@ test.describe('public links', () => {
 
     await freshContext.close()
   })
+
+  test('scrollTo works on public link', async ({ browser }) => {
+    await pastebin.navigateToPastebin()
+    const { password } = await pastebin.createPastebin({
+      files: [
+        { name: 'top.py', content: '# this is the top file\n'.repeat(30) },
+        { name: 'bottom.js', content: '// this is the bottom file' }
+      ]
+    })
+
+    await pastebin.expectFileVisible('top.py')
+    await pastebin.expectFileVisible('bottom.js')
+
+    // wait for share URL to resolve, then get anchor href for bottom file
+    const linkIcon = userPage.locator('header a[title="Open public link"]')
+    await expect(linkIcon).toBeVisible({ timeout: 15000 })
+    const anchorHref = await pastebin.getAnchorHref('bottom.js')
+    expect(anchorHref).toContain('scrollTo=bottom.js')
+
+    // open the anchor link in a fresh unauthenticated context
+    const freshContext = await browser.newContext({ ignoreHTTPSErrors: true })
+    const freshPage = await freshContext.newPage()
+    await freshPage.goto(anchorHref!, { timeout: 30000 })
+
+    if (password) {
+      const passwordField = freshPage.locator('input[type="password"]')
+      await expect(passwordField).toBeVisible({ timeout: 15000 })
+      await passwordField.fill(password)
+      await freshPage.getByRole('button', { name: 'Continue', exact: true }).click()
+    }
+
+    // the bottom file should be visible (scrolled into view)
+    await expect(freshPage.locator('[data-item-id="bottom.js"]')).toBeVisible({ timeout: 15000 })
+
+    await freshContext.close()
+  })
 })
 
 test.describe('navigation', () => {