[Fix] Fix get_installed_path for python3.12 and editable installed package

Author: HAOCHENYE

mmengine/utils/package_utils.py

@@ -2,7 +2,6 @@
 import os.path as osp
 import subprocess
 from importlib.metadata import PackageNotFoundError, distribution
-from typing import Any
 
 
 def is_installed(package: str) -> bool:
@@ -32,64 +31,62 @@ def get_installed_path(package: str) -> str:
     Args:
         package (str): Name of package.
 
+    Returns:
+        str: The installed path of the package.
+
     Example:
         >>> get_installed_path('mmcls')
         >>> '.../lib/python3.7/site-packages/mmcls'
     """
     import importlib.util
 
-    # if the package name is not the same as module name, module name should be
-    # inferred. For example, mmcv-full is the package name, but mmcv is module
-    # name. If we want to get the installed path of mmcv-full, we should concat
-    # the pkg.location and module name
-    # Try to get location from distribution package metadata
-    location = None
-    try:
-        dist = distribution(package)
-        locate_result: Any = dist.locate_file('')
-        location = str(locate_result.parent)
-    except PackageNotFoundError:
-        pass
-
-    # If distribution package not found, try to find via importlib
-    if location is None:
-        spec = importlib.util.find_spec(package)
-        if spec is not None:
-            if spec.origin is not None:
-                return osp.dirname(spec.origin)
-            else:
-                # `get_installed_path` cannot get the installed path of
-                # namespace packages
-                raise RuntimeError(
-                    f'{package} is a namespace package, which is invalid '
-                    'for `get_install_path`')
-        else:
-            raise PackageNotFoundError(f'Package {package} is not installed')
-
-    # Check if package directory exists in the location
-    possible_path = osp.join(location, package)
-    if osp.exists(possible_path):
-        return possible_path
-    else:
-        return osp.join(location, package2module(package))
+    # Resolve the location through the import machinery rather than the
+    # distribution `location`. `find_spec` correctly handles regular,
+    # editable (installs that expose the module via a `.pth`/import hook while
+    # the files live outside site-packages), and `PYTHONPATH` installs, whereas
+    # distribution metadata reports the site-packages directory even when the
+    # module is not physically there.
+    module_name = package2module(package)
+    spec = importlib.util.find_spec(module_name)
+    if spec is None:
+        raise PackageNotFoundError(f'Package {package} is not installed')
+
+    if spec.origin is not None:
+        return osp.dirname(spec.origin)
+    if spec.submodule_search_locations:
+        return spec.submodule_search_locations[0]
+    # A namespace package has neither an origin nor a single concrete location.
+    raise RuntimeError(
+        f'{package} is a namespace package, which is invalid for '
+        '`get_installed_path`')
 
 
 def package2module(package: str) -> str:
     """Infer module name from package.
 
     Args:
         package (str): Package to infer module name.
+
+    Returns:
+        str: The inferred module name.
     """
-    dist = distribution(package)
+    import importlib.util
 
-    # In importlib.metadata,
-    # top-level modules are in dist.read_text('top_level.txt')
+    # The importable module name usually matches the package name. Probing the
+    # import machinery first also covers editable installs, whose
+    # `top_level.txt` may be absent even though the module is importable.
+    if importlib.util.find_spec(package) is not None:
+        return package
+
+    # Distribution name differs from the module name (e.g. `mmcv-full` ->
+    # `mmcv`); recover the top-level module from distribution metadata.
+    dist = distribution(package)
     top_level_text = dist.read_text('top_level.txt')
     if top_level_text is not None:
-        lines = top_level_text.strip().split('\n')
+        lines = [line.strip() for line in top_level_text.splitlines()
+                 if line.strip()]
         if lines:
-            module_name = lines[0].strip()
-            return module_name
+            return lines[0]
     raise ValueError(f'can not infer the module name of {package}')