demo null value defaulting

Signed-off-by: Todd Baert <[email protected]>

Author: toddbaert

libs/providers/ofrep-web/src/lib/ofrep-web-provider.ts

@@ -299,6 +299,14 @@ export class OFREPWebProvider implements Provider {
       };
     }
 
+    if (resolved.value === undefined || resolved.value === null) {
+      return {
+        value: defaultValue,
+        flagMetadata: resolved.flagMetadata,
+        reason: resolved.reason || StandardResolutionReasons.DEFAULT,
+      };
+    }
+
     if (typeof resolved.value !== type) {
       return {
         value: defaultValue,

libs/providers/ofrep/src/lib/ofrep-provider.spec.ts

@@ -60,6 +60,16 @@ describe('OFREPProvider should', () => {
     );
   });
 
+  it.each([true, false])('returns default if value is null', async (defaultValue) => {
+    await expect(provider.resolveBooleanEvaluation('my-null-value-flag', defaultValue, {})).resolves.toStrictEqual(
+      expect.objectContaining({
+        value: defaultValue,
+        reason: 'DEFAULT',
+        flagMetadata: expect.objectContaining(TEST_FLAG_METADATA),
+      }),
+    );
+  });
+
   it('throw OFREPApiUnauthorizedError on HTTP 401', async () => {
     await expect(provider.resolveBooleanEvaluation('my-flag', false, { expectedAuthHeader: 'secret' })).rejects.toThrow(
       OFREPApiUnauthorizedError,

libs/providers/ofrep/src/lib/ofrep-provider.ts

@@ -94,7 +94,11 @@ export class OFREPProvider implements Provider {
       return handleEvaluationError(result, defaultValue);
     }
 
-    if (typeof result.value.value !== typeof defaultValue) {
+    if (
+      result.value.value !== undefined &&
+      result.value.value !== null &&
+      typeof result.value.value !== typeof defaultValue
+    ) {
       return {
         value: defaultValue,
         reason: StandardResolutionReasons.ERROR,
@@ -104,6 +108,6 @@ export class OFREPProvider implements Provider {
       };
     }
 
-    return toResolutionDetails(result.value);
+    return toResolutionDetails(result.value, defaultValue);
   }
 }

libs/shared/ofrep-core/src/lib/api/ofrep-api.ts

@@ -191,13 +191,22 @@ export function handleEvaluationError<T>(
 
 export function toResolutionDetails<T extends EvaluationFlagValue>(
   result: EvaluationSuccessResponse,
+  defaultValue: T,
 ): ResolutionDetails<T> {
-  return {
-    value: result.value as T,
-    variant: result.variant,
-    reason: result.reason,
-    flagMetadata: result.metadata && toFlagMetadata(result.metadata),
-  };
+  if (result.value === undefined || result.value === null) {
+    return {
+      value: defaultValue,
+      reason: result.reason || StandardResolutionReasons.DEFAULT,
+      flagMetadata: result.metadata && toFlagMetadata(result.metadata),
+    };
+  } else {
+    return {
+      value: result.value as T,
+      variant: result.variant,
+      reason: result.reason,
+      flagMetadata: result.metadata && toFlagMetadata(result.metadata),
+    };
+  }
 }
 
 export function toFlagMetadata(metadata: object): FlagMetadata {

libs/shared/ofrep-core/src/test/handlers.ts

@@ -121,14 +121,20 @@ export const handlers = [
       }
 
       const scopeValue = new URL(info.request.url).searchParams.get('scope');
+      const key = info.params.key;
+      const reason = key.includes('null-value')
+        ? StandardResolutionReasons.DEFAULT
+        : requestBody.context?.targetingKey
+          ? StandardResolutionReasons.TARGETING_MATCH
+          : StandardResolutionReasons.STATIC;
+
+      const value = key.includes('null-value') ? null : true;
 
       return HttpResponse.json<EvaluationResponse>({
         key: info.params.key,
-        reason: requestBody.context?.targetingKey
-          ? StandardResolutionReasons.TARGETING_MATCH
-          : StandardResolutionReasons.STATIC,
+        reason,
         variant: scopeValue ? 'scoped' : 'default',
-        value: true,
+        value,
         metadata: TEST_FLAG_METADATA,
       });
     },