Skip to content

Commit 0286738

Browse files
committed
fixup: improve based on gemini feedback
Signed-off-by: Simon Schrottner <[email protected]>
1 parent b6c9664 commit 0286738

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

providers/flagd/pkg/provider.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,11 @@ func NewProvider(opts ...ProviderOption) (*Provider, error) {
8181
})
8282
}
8383

84-
provider.hooks = append(provider.hooks, NewSyncContextHook(func() *of.EvaluationContext {
85-
return provider.providerConfiguration.ContextEnricher(service.ContextValues())
86-
}))
84+
if provider.providerConfiguration.Resolver == inProcess {
85+
provider.hooks = append(provider.hooks, NewSyncContextHook(func() *of.EvaluationContext {
86+
return provider.providerConfiguration.ContextEnricher(service.ContextValues())
87+
}))
88+
}
8789
provider.service = service
8890

8991
return provider, nil

providers/flagd/pkg/service/in_process/service.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,9 @@ func (i *InProcess) Init() error {
115115
// re-syncs are ignored as we only support single flag sync source
116116
changes, _, err := i.evaluator.SetState(data)
117117
if data.SyncContext != nil {
118+
i.mtx.Lock()
118119
i.contextValues = data.SyncContext.AsMap()
120+
i.mtx.Unlock()
119121
}
120122

121123
if err != nil {

tests/flagd/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ toolchain go1.24.4
66

77
require (
88
github.com/cucumber/godog v0.15.1
9+
github.com/docker/go-connections v0.5.0
910
github.com/open-feature/go-sdk v1.11.0
1011
github.com/open-feature/go-sdk-contrib/providers/flagd v0.3.0
1112
github.com/testcontainers/testcontainers-go v0.38.0
@@ -70,7 +71,6 @@ require (
7071
github.com/docker/docker v28.2.2+incompatible // indirect
7172
github.com/docker/docker-credential-helpers v0.8.2 // indirect
7273
github.com/docker/go v1.5.1-1.0.20160303222718-d30aec9fd63c // indirect
73-
github.com/docker/go-connections v0.5.0 // indirect
7474
github.com/docker/go-metrics v0.0.1 // indirect
7575
github.com/docker/go-units v0.5.0 // indirect
7676
github.com/ebitengine/purego v0.8.4 // indirect

0 commit comments

Comments
 (0)