Spike not renewing subscription providables if the user is on grace period.

[thierroboto]

Hi,

I just found a major issue with the system that renewas the subscription providables:

if ($this->isOnGracePeriod($spikeSubscription)) {
            if ($this->shouldShowDebugInfo($verbosity)) {
                $this->logDebug($output, "  [$modelClass:{$billable->getKey()}] Subscription is on grace period. Expiring providables...");
            }

            app(ExpireSubscriptionProvidables::class)
                ->handle($billable, $spikeSubscription, null, $this->shouldShowDebugInfo($verbosity));
        } else {

Basically, let's say a user has an annual subscription and cancels his subscription after a few days, the subscription is scheduled to be deleted a year from now, however since he is on a grace period, spike will expire his credits instead of renewing them every month until the cancellation date. This shouldn't happen, at least not for annual subscriptions.