Skip to content

Replace hardcoded ERC-20 ABI with JSON file import and eliminate magic numbers #22

@ongrid

Description

@ongrid

Currently, the ERC-20 ABI is hardcoded in the Python consts with magic numbers and partial dictionary structures that are difficult to maintain and extend.

See:

Issues:

  1. Hardcoded ABI: ABI definition is embedded in Python code without clean structure of artifacts
  2. Incomplete ABI: Only includes balanceOf function and Transfer topic, missing other standard ERC-20 functions (like allowances) and events (approvals). See: Check ERC-20 token approvals from skeeper to balance manager #19
  3. Maintainability: Adding monitoring of new contracts require adding new magic numbers without clear structure See Replace individual balanceOfcalls with a single Multicall contract call #16

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions