[WIP] temp

Author: Goaman

src/runtime/component_node.ts

@@ -106,7 +106,7 @@ export class ComponentNode<P extends Props = any, E = any> implements VNode<Comp
       value: undefined,
       compute: () => this.render(false),
       sources: new Set<Atom>(),
-      state: ComputationState.STALE,
+      state: ComputationState.EXECUTED,
     };
     const defaultProps = C.defaultProps;
     props = Object.assign({}, props);
@@ -138,10 +138,11 @@ export class ComponentNode<P extends Props = any, E = any> implements VNode<Comp
     }
     const component = this.component;
     try {
-      const previousComputation = getCurrentComputation();
-      setComputation(undefined);
-      await Promise.all(this.willStart.map((f) => withoutReactivity(() => f.call(component))));
-      setComputation(previousComputation);
+      let prom: Promise<any[]>;
+      withoutReactivity(() => {
+        prom = Promise.all(this.willStart.map((f) => f.call(component)));
+      });
+      await prom!;
     } catch (e) {
       this.app.handleError({ node: this, error: e });
       return;
@@ -256,11 +257,11 @@ export class ComponentNode<P extends Props = any, E = any> implements VNode<Comp
       applyDefaultProps(props, defaultProps);
     }
 
-    const previouwsComputation = getCurrentComputation();
-    setComputation(undefined);
-    await Promise.all(this.willUpdateProps.map((f) => f.call(component, props)));
-    setComputation(previouwsComputation);
-
+    let prom: Promise<any[]>;
+    withoutReactivity(() => {
+      prom = Promise.all(this.willUpdateProps.map((f) => f.call(component, props)));
+    });
+    await prom!;
     if (fiber !== this.fiber) {
       return;
     }

src/runtime/fibers.ts

@@ -4,7 +4,7 @@ import { fibersInError } from "./error_handling";
 import { OwlError } from "../common/owl_error";
 import { STATUS } from "./status";
 import { runWithComputation } from "./signals";
-import { ComputationState } from "../common/types";
+// import { ComputationState } from "../common/types";
 
 export function makeChildFiber(node: ComponentNode, parent: Fiber): Fiber {
   let current = node.fiber;
@@ -143,7 +143,7 @@ export class Fiber {
         } catch (e) {
           node.app.handleError({ node, error: e });
         }
-        node.signalComputation.state = ComputationState.EXECUTED;
+        // node.signalComputation.state = ComputationState.EXECUTED;
       });
       root.setCounter(root.counter - 1);
     }

src/runtime/signals.ts

@@ -38,9 +38,9 @@ export function effect<T>(fn: () => T, opts?: Opts) {
       return fn();
     },
     sources: new Set(),
+    childrenEffect: [],
     name: opts?.name,
   };
-  effectComputation.childrenEffect = [];
   CurrentComputation?.childrenEffect?.push?.(effectComputation);
   updateComputation(effectComputation);
 
@@ -54,20 +54,20 @@ export function effect<T>(fn: () => T, opts?: Opts) {
     CurrentComputation = previousComputation!;
   };
 }
-export function computed<T>(fn: () => T, opts?: Opts) {
-  // todo: handle cleanup
-  let computedComputation: Computation = {
-    state: ComputationState.STALE,
-    sources: new Set(),
-    isEager: true,
-    compute: () => {
-      return fn();
-    },
-    value: undefined,
-    name: opts?.name,
-  };
-  updateComputation(computedComputation);
-}
+// export function computed<T>(fn: () => T, opts?: Opts) {
+//   // todo: handle cleanup
+//   let computedComputation: Computation = {
+//     state: ComputationState.STALE,
+//     sources: new Set(),
+//     isEager: true,
+//     compute: () => {
+//       return fn();
+//     },
+//     value: undefined,
+//     name: opts?.name,
+//   };
+//   updateComputation(computedComputation);
+// }
 export function derived<T>(fn: () => T, opts?: Opts): () => T {
   // todo: handle cleanup
   let derivedComputation: Derived<any, any>;

tests/components/__snapshots__/props_validation.test.ts.snap

@@ -880,33 +880,6 @@ exports[`props validation props are validated whenever component is updated 2`]
 }"
 `;
 
-exports[`props validation props validation does not cause additional subscription 1`] = `
-"function anonymous(app, bdom, helpers
-) {
-  let { text, createBlock, list, multi, html, toggler, comment } = bdom;
-  const comp1 = app.createComponent(\`Child\`, true, false, false, [\\"obj\\"]);
-  
-  return function template(ctx, node, key = \\"\\") {
-    const props1 = {obj: ctx['obj']};
-    helpers.validateProps(\`Child\`, props1, this);
-    const b2 = comp1(props1, key + \`__1\`, node, this, null);
-    const b3 = text(ctx['obj'].otherValue);
-    return multi([b2, b3]);
-  }
-}"
-`;
-
-exports[`props validation props validation does not cause additional subscription 2`] = `
-"function anonymous(app, bdom, helpers
-) {
-  let { text, createBlock, list, multi, html, toggler, comment } = bdom;
-  
-  return function template(ctx, node, key = \\"\\") {
-    return text(ctx['props'].obj.value);
-  }
-}"
-`;
-
 exports[`props validation props: list of strings 1`] = `
 "function anonymous(app, bdom, helpers
 ) {

tests/components/lifecycle.test.ts

@@ -995,7 +995,7 @@ describe("lifecycle hooks", () => {
     `);
   });
 
-  test.only("onWillRender", async () => {
+  test("onWillRender", async () => {
     const def = makeDeferred();
 
     class Child extends Component {

tests/components/props_validation.test.ts

@@ -1,5 +1,5 @@
 import { makeTestFixture, nextAppError, nextTick, snapshotEverything } from "../helpers";
-import { Component, onError, xml, mount, OwlError, useState } from "../../src";
+import { Component, onError, xml, mount, OwlError } from "../../src";
 import { App } from "../../src/runtime/app";
 import { validateProps } from "../../src/runtime/template_helpers";
 import { Schema } from "../../src/runtime/validation";