./install.sh fail on new installation

[lse-odoo]

Criticality

Low

What happened?

I was trying to install odev on a new computer, but it failed consistently while trying to run the installation script.
The script try to find a plugins folder which looks to not exist in odev repository prior to the install. SEe:
https://github.com/odoo-odev/odev/blame/4b4b667c46c487c911d916c33f7776e146f9ce7a/install.sh#L41

Relevant log output

Setting up virtual environment
Installing dependencies
find: ‘odev/plugins/*/’: No such file or directory
Adding executable to available commands
You might be prompted for your password to create a symlink in /usr/local/bin
ln: failed to create symbolic link '/usr/local/bin/odev': No such file or directory
Failed to add executable to PATH

What is expected?

Run install script without errors

Possible implementation

No response

Additional information

No response

[lse-odoo]

Also regargind the second issue;

ls /usr/local/
etc/    games/  lib/    man@    sbin/   share/  src/ 

[rkingkong]

I can reproduce this on a fresh machine: find odev/plugins/*/ fails when odev/plugins doesn’t exist yet (or is empty), which makes the install look broken even though it’s just “no plugins”.

Suggest guarding that find behind a [[ -d odev/plugins ]] check (or ignore find’s exit code when the glob matches nothing).

Re: the symlink error — on my box /usr/local/bin didn’t exist either, so ln fails.

A mkdir -p /usr/local/bin before linking fixes it, or we could fall back to ~/.local/bin when /usr/local/bin isn’t present/writable.

[brinkflew]

Thank you both for the debugging on this.

Working on a fix in #130